Properly reset fields in clean_unrhdr.
ClosedPublic
Actions

Authored by mjoras on Oct 13 2017, 5:17 PM.

Tags

None

Referenced Files

	F161285549: D12662.diff
	Thu, Jul 2, 11:05 AM

	F161231113: D12662.diff
	Wed, Jul 1, 11:08 PM

	F161222697: D12662.id33999.diff
	Wed, Jul 1, 8:50 PM

	Unknown Object (File)
	Wed, Jun 17, 10:56 PM

	Unknown Object (File)
	Sun, Jun 7, 4:46 AM

	Unknown Object (File)
	Thu, Jun 4, 9:17 PM

	Unknown Object (File)
	Jun 1 2026, 10:07 PM

	Unknown Object (File)
	Jun 1 2026, 5:30 PM

View All Files

Subscribers

imp

Details

Reviewers

rstone

Summary

In r324542 I neglected to reset the first and last fields of struct
unrhdr. This causes a tmpfs to fail the unr(9) consistency checks with
DIAGNOSTIC on. Fix this by resetting the fields to be as if init_unrhdr
was called.

Test Plan

Tested using a tmpfs with an extracted ports tree, unmounted with DIAGNOSTIC
on.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12053
Build 12360: arc lint + arc unit

Event Timeline

mjoras created this revision.Oct 13 2017, 5:17 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 13 2017, 5:17 PM

use init_unrhdr instead of duplicating it

Harbormaster completed remote builds in B12040: Diff 33970.Oct 13 2017, 8:30 PM

Might as well use TAILQ_FOREACH_SAFE while we are here.

Harbormaster completed remote builds in B12053: Diff 33999.Oct 14 2017, 11:58 PM

rstone accepted this revision.Oct 16 2017, 3:40 PM

This revision is now accepted and ready to land.Oct 16 2017, 3:40 PM

mjoras closed this revision.Oct 16 2017, 4:23 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_unit.c

9 lines

Diff 33999

View Options

Properly reset fields in clean_unrhdr.ClosedPublicActions