Implement bhnd(4) platform device registration.
ClosedPublic
Actions

Authored by landonf on Sep 16 2017, 4:06 AM.

Details

Reviewers

Commits

rS324070: bhnd: Implement bhnd(4) platform device registration.

Summary

Add bhnd(4) API for explicitly registering BHND platform devices with the bus, rather than walking the newbus hierarchy to discover platform devices (ChipCommon, PMU, NVRAM, etc). These devices are now also refcounted; attempting to deregister an actively used platform device will return EBUSY.

This resolves a lock ordering issue with bwn(4)'s firmware loading threads; previously it was necessary to acquire Giant to protect newbus access when locating and querying the NVRAM device.

Test Plan

Tested for regressions against both Broadcom MIPS SoCs and Wi-Fi chipsets.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11769
Build 12113: arc lint + arc unit

Event Timeline

landonf created this revision.Sep 16 2017, 4:06 AM

Harbormaster completed remote builds in B11601: Diff 33145.Sep 16 2017, 4:06 AM

Adopt a non-sleepable lock for the bhnd_service_registry; this allows use of
bhnd_service_registry_retain() while holding either an unbounded or bounded
sleep lock.

Harbormaster completed remote builds in B11769: Diff 33464.Sep 26 2017, 9:01 PM

landonf added a child revision: D12510: Add support for supplying bus I/O callbacks when initializing an EROM parser..Sep 26 2017, 9:06 PM

adrian accepted this revision.Sep 27 2017, 1:50 AM

This revision is now accepted and ready to land.Sep 27 2017, 1:50 AM

Closed by commit rS324070: bhnd: Implement bhnd(4) platform device registration. (authored by landonf). · Explain WhySep 27 2017, 7:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

bhnd/

175 lines

410 lines

104 lines

55 lines

660 lines

14 lines

bhndb/

6 lines

40 lines

8 lines

81 lines

cores/

chipc/

chipc.c

13 lines

pwrctl/

bhnd_pwrctl.c

25 lines

pci/

bhnd_pci_hostb.c

8 lines

pmu/

bhnd_pmu.c

19 lines

nvram/

bhnd_sprom.c

26 lines

siba/

siba_bhndb.c

12 lines

mips/

broadcom/

32 lines

11 lines

21 lines

20 lines

Commit	Tree	Parents	Author	Summary	Date
e34abe699588	97713a56ae39	cdf553a0d1cf	Landon Fuller	Adopt a non-sleepable lock for the bhnd_service_registry; this allows use of… (Show More…)	Sep 26 2017, 8:44 PM
cdf553a0d1cf	d6dd5527875c	ca2691b9e900 59d84271534d	Landon Fuller	Merge branch 'master' into user/landonf/bwn_fbsdf/M1/0001_provider_device	Sep 18 2017, 7:34 PM
ca2691b9e900	f2db11c08ef7	9e9a4b15a01a	Landon Fuller	Minor comment copyedits.	Sep 15 2017, 11:55 PM
9e9a4b15a01a	66a85fe2b196	2b21ff435356	Landon Fuller	Minor documentation comment edits.	Sep 15 2017, 11:49 PM
2b21ff435356	7fbfc90d9de6	bee83500d072	Landon Fuller	Add a documentation comment for the service provider flag enum.	Sep 15 2017, 11:46 PM
bee83500d072	eab4c3439af7	da8ac1422214	Landon Fuller	Drop unnecessary whitespace delta from master.	Sep 15 2017, 11:45 PM
da8ac1422214	2198b7f38bd7	c4a661d817a6	Landon Fuller	Fix leak of PMU provider reference.	Sep 15 2017, 11:42 PM
c4a661d817a6	c3c7e61d2fff	a7b434df14be 4c4cbd798b57	Landon Fuller	Merge branch 'master' into user/landonf/bwn_fbsdf/M1/0001_provider_device	Sep 15 2017, 7:59 PM
a7b434df14be	78e85cb328f8	ed516ad3e0ff 99c641b97cd8	Landon Fuller	Merge branch 'master' into user/landonf/bwn_fbsdf/M1/0001_provider_device	Sep 13 2017, 2:10 AM
ed516ad3e0ff	699f03b55432	72ff88f1918c 3145ad5e1830	Landon Fuller	Merge branch 'master' into user/landonf/bwn_fbsdf/M1/0001_provider_device	Sep 9 2017, 7:08 PM
72ff88f1918c	202136315999	542212be200c 048f93ec6e65	Landon Fuller	Merge branch 'master' into user/landonf/bwn_fbsdf/M1/0001_provider_device	Sep 7 2017, 12:27 AM
542212be200c	46f6d1d7063e	181eb063a252 03fd2a83b9c2	Landon Fuller	Merge branch 'master' into user/landonf/bwn_fbsdf/M1/0001_provider_device	Sep 6 2017, 11:51 PM
181eb063a252	7aa14801a492	2ded9a8648c2	Landon Fuller	Replace the opaque info pointer with a well-defined flag and invariants… (Show More…)	Sep 5 2017, 7:17 PM
2ded9a8648c2	2d3e082dfb8c	983108980511	Landon Fuller	Update copyright notices for modified files.	Sep 4 2017, 9:59 PM
983108980511	88600838beb3	9200bc0a67a9	Landon Fuller	Add ChipCommon service provider registration.	Sep 4 2017, 9:49 PM
9200bc0a67a9	6ef8ea7c144b	1939ab5f8b7c	Landon Fuller	Add missing locking in bhnd_pwrctl_detach().	Sep 4 2017, 9:15 PM
1939ab5f8b7c	53655b3ddeca	c5559087b6b2	Landon Fuller	Add missing (un-)locking in the service registry, fix inverted invalid… (Show More…)	Sep 4 2017, 9:10 PM
c5559087b6b2	4579403cae30	eeee070b22d3	Landon Fuller	Provide MIPS platform-level bhnd service registration, and use it to register… (Show More…)	Sep 4 2017, 9:03 PM
eeee070b22d3	d84110263af2	2e0341dbd004	Landon Fuller	Provide a bridge-level service registry	Sep 4 2017, 6:40 PM
2e0341dbd004	f37d17d382ed	4ab3c51ec05f	Landon Fuller	If no local provider is found, delegate service provider lookups to the parent… (Show More…)	Sep 4 2017, 6:26 PM
4ab3c51ec05f	8a52998d82f2	6865609aba25	Landon Fuller	Assume all service providers are device_t instances.	Sep 4 2017, 6:08 PM
6865609aba25	7ad5b2fb2d16	512e3c86742e	Landon Fuller	Return EEXIST if a service provider is already registered.	Sep 4 2017, 5:57 PM
512e3c86742e	1f05ab6667cd	3c9af445f21c	Landon Fuller	Define a new bhnd_service_registry type, modeled roughly on resource_list, to… (Show More…)	Sep 3 2017, 5:24 AM
3c9af445f21c	f38b8eb0bfd5	28136d7efb06	Landon Fuller	Check for (and panic on) invalid provider device references when releasing a… (Show More…)	Sep 2 2017, 4:13 AM
28136d7efb06	eb65d01bacaa	e698e41834b7	Landon Fuller	Adopt the new provider registration API for NVRAM lookups.	Sep 2 2017, 4:10 AM
e698e41834b7	b1c1daa228ec	7c8118b494ee	Landon Fuller	Adopt new provider API for handling PMU requests.	Sep 2 2017, 12:57 AM
7c8118b494ee	b0b3dcf76d1e	365a1fc6761c	Landon Fuller	Simplify the BHND_BUS_RETAIN_PROVIDER() API	Sep 2 2017, 12:50 AM
365a1fc6761c	e00bce316b63	8a80e851e6a0	Landon Fuller	Implement basic (but still unused) platform device registration.	Sep 2 2017, 12:23 AM
8a80e851e6a0	3312f2dc4789	4a46bbef9540	Landon Fuller	Add a standalone bhnd_bus_probe_children() utility function; this will allow us… (Show More…)	Sep 1 2017, 11:20 PM
4a46bbef9540	bbdaa6430e1a	0aedc2b174f9	Landon Fuller	Lift bhnd device array sorting out into public API.	Sep 1 2017, 11:13 PM
0aedc2b174f9	4694ad4e9242	4354bd49e37c	Landon Fuller	Use a 'bhnd_bus' prefix to differentiate bus-level bhnd(4) functions from… (Show More…)	Sep 1 2017, 10:35 PM
4354bd49e37c	9a5d5be482fd	b1faea1b5ea4	Landon Fuller	Define bhnd(4) provider registration data structures.	Sep 1 2017, 8:12 PM
b1faea1b5ea4	cb6a0c93a7ea	2f8caa5c34c9	Landon Fuller	Update copyright header.	Sep 1 2017, 7:18 PM
2f8caa5c34c9	b1866423a3cd	44faa360993a	Landon Fuller	Do not return an error in BHND_BUS_DEREGISTER_PROVIDER() if the device is not… (Show More…)	Sep 1 2017, 7:14 PM
44faa360993a	0846caf5f703	c7be2484576f	Landon Fuller	Rename bhnd_prov_t to bhnd_provider_type, document the new provider types, and… (Show More…)	Sep 1 2017, 7:06 PM
c7be2484576f	555d208ddd74	bfd734f77c34	Landon Fuller	Stub out bhnd(4) platform device registration.	Sep 1 2017, 6:55 PM