Implement bhnd(4) platform device registration.
ClosedPublic
Actions

Authored by landonf on Sep 16 2017, 4:06 AM.

Details

Reviewers

Commits

rS324070: bhnd: Implement bhnd(4) platform device registration.

Summary

Add bhnd(4) API for explicitly registering BHND platform devices with the bus, rather than walking the newbus hierarchy to discover platform devices (ChipCommon, PMU, NVRAM, etc). These devices are now also refcounted; attempting to deregister an actively used platform device will return EBUSY.

This resolves a lock ordering issue with bwn(4)'s firmware loading threads; previously it was necessary to acquire Giant to protect newbus access when locating and querying the NVRAM device.

Test Plan

Tested for regressions against both Broadcom MIPS SoCs and Wi-Fi chipsets.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

landonf created this revision.Sep 16 2017, 4:06 AM

Harbormaster completed remote builds in B11601: Diff 33145.Sep 16 2017, 4:06 AM

Adopt a non-sleepable lock for the bhnd_service_registry; this allows use of
bhnd_service_registry_retain() while holding either an unbounded or bounded
sleep lock.

Harbormaster completed remote builds in B11769: Diff 33464.Sep 26 2017, 9:01 PM

landonf added a child revision: D12510: Add support for supplying bus I/O callbacks when initializing an EROM parser..Sep 26 2017, 9:06 PM

adrian accepted this revision.Sep 27 2017, 1:50 AM

This revision is now accepted and ready to land.Sep 27 2017, 1:50 AM

Closed by commit rS324070: bhnd: Implement bhnd(4) platform device registration. (authored by landonf). · Explain WhySep 27 2017, 7:44 PM

This revision was automatically updated to reflect the committed changes.