Page MenuHomeFreeBSD
Differential D12434

Move MI bits of efirt to a MI file
ClosedPublic
Actions

Authored by andrew on Sep 21 2017, 1:48 PM.
Tags
None
Referenced Files
F105704234: D12434.diff
Thu, Dec 19, 10:59 AM
Unknown Object (File)
Nov 5 2024, 6:07 AM
Unknown Object (File)
Nov 3 2024, 6:06 AM
Unknown Object (File)
Oct 2 2024, 5:23 PM
Unknown Object (File)
Oct 2 2024, 9:02 AM
Unknown Object (File)
Oct 1 2024, 4:09 PM
Unknown Object (File)
Sep 30 2024, 2:03 PM
Unknown Object (File)
Sep 30 2024, 1:44 PM
View All 61 Files
Subscribers
None

Details

Reviewers
imp
kib
Commits
rS324177: To prepare for adding EFI runtime services support on arm64 move the
Summary

To prepare for adding EFI runtime services support on arm64 move the
machine independent parts of the existing code to a new file that can
be shared between the two architectures.

Test Plan

I've tested on arm64, but don't have an amd64 test machine so haven't tested there.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11675
Build 12021: arc lint + arc unit

Event Timeline

andrew created this revision.Sep 21 2017, 1:48 PM
kib added a comment.Sep 21 2017, 5:12 PM

So the 1:1 mapping trick is becoming the arch requirement to support RT ?

sys/kern/subr_efi.c
64

Why is this in MD file ?

andrew updated this revision to Diff 33306.Sep 22 2017, 9:31 AM
  • Move the locking macros to a MD header
  • Ddd subr_efi.c to the module Makefile
Harbormaster completed remote builds in B11675: Diff 33306.Sep 22 2017, 9:31 AM
andrew added a comment.Sep 22 2017, 9:59 AM

I left the name as it all architectures that currently support EFI RT use a 1:1 map.

kib accepted this revision.Sep 22 2017, 1:12 PM

May be add sys/dev/efirt and move subr_efi.c there ? EFI is not a generic facility, it is MD, just that it exists on both x86 and arm64.

This revision is now accepted and ready to land.Sep 22 2017, 1:12 PM
imp added a comment.Sep 22 2017, 2:37 PM

My eye didn't trip over anything...

andrew updated this revision to Diff 33378.Sep 24 2017, 11:32 AM

Move the MI file under sys/dev/efidev

This revision now requires review to proceed.Sep 24 2017, 11:32 AM
Harbormaster completed remote builds in B11716: Diff 33378.Sep 24 2017, 11:32 AM
imp accepted this revision.Sep 24 2017, 2:24 PM

I like this layout better...

This revision is now accepted and ready to land.Sep 24 2017, 2:24 PM
Closed by commit rS324177: To prepare for adding EFI runtime services support on arm64 move the (authored by andrew). · Explain WhyOct 1 2017, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
320 lines
include/
22 lines
conf/
1 line
kern/
subr_efi.c/
amd64/
amd64/
efirt.c
325 lines
modules/
efirt/
3 lines
sys/
19 lines

Diff 33306

View Options

sys/amd64/amd64/efirt.c

Loading...
View Options

sys/amd64/include/efi.h

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/kern/subr_efi.c

Loading...
View Options

sys/modules/efirt/Makefile

Loading...
View Options

sys/sys/efi.h

Loading...