Do not do torn writes to active LDTs.
ClosedPublic
Actions

Authored by kib on Sep 19 2017, 12:33 PM.

Details

Reviewers

Commits

rS323772: Do not do torn writes to active LDTs.

Summary

Care must be taken when updating the active LDT, since parallel threads might try to load a segment descriptor which is currently updated. Since the results are undefined, this cannot be ignored by claiming to be an application race.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 11630

Event Timeline

kib created this revision.Sep 19 2017, 12:33 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 19 2017, 12:33 PM

jhb accepted this revision.Sep 19 2017, 4:59 PM

This revision is now accepted and ready to land.Sep 19 2017, 4:59 PM

Closed by commit rS323772: Do not do torn writes to active LDTs. (authored by kib). · Explain WhySep 19 2017, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

sys_machdep.c

35 lines

i386/

sys_machdep.c

34 lines

Diff 33220

View Options

sys/amd64/amd64/sys_machdep.c

	Show First 20 Lines • Show All 370 Lines • ▼ Show 20 Lines
	# VirtIO support			# VirtIO support
	device virtio # Generic VirtIO bus (required)			device virtio # Generic VirtIO bus (required)
	device virtio_pci # VirtIO PCI device			device virtio_pci # VirtIO PCI device
	device vtnet # VirtIO Ethernet device			device vtnet # VirtIO Ethernet device
	device virtio_blk # VirtIO Block device			device virtio_blk # VirtIO Block device
	device virtio_scsi # VirtIO SCSI device			device virtio_scsi # VirtIO SCSI device
	device virtio_balloon # VirtIO Memory Balloon device			device virtio_balloon # VirtIO Memory Balloon device

				# Linux KVM paravirtualization support
				device kvm_clock # KVM paravirtual clock driver

	# HyperV drivers and enhancement support			# HyperV drivers and enhancement support
	device hyperv # HyperV drivers			device hyperv # HyperV drivers

	# Xen HVM Guest Optimizations			# Xen HVM Guest Optimizations
	# NOTE: XENHVM depends on xenpci. They must be added or removed together.			# NOTE: XENHVM depends on xenpci. They must be added or removed together.
	options XENHVM # Xen HVM kernel infrastructure			options XENHVM # Xen HVM kernel infrastructure
	device xenpci # Xen HVM Hypervisor services driver			device xenpci # Xen HVM Hypervisor services driver

	Show All 12 Lines