Page MenuHomeFreeBSD

OBJS_SRCS_FILTER
ClosedPublic

Authored by sjg on Sep 3 2017, 3:32 AM.
Tags
None
Referenced Files
F106135051: D12218.diff
Wed, Dec 25, 11:43 PM
Unknown Object (File)
Nov 24 2024, 10:14 PM
Unknown Object (File)
Nov 23 2024, 4:45 AM
Unknown Object (File)
Nov 22 2024, 3:48 PM
Unknown Object (File)
Nov 22 2024, 1:20 PM
Unknown Object (File)
Nov 22 2024, 1:20 PM
Unknown Object (File)
Nov 21 2024, 2:01 PM
Unknown Object (File)
Nov 19 2024, 1:38 PM
Subscribers

Details

Summary

Allow makefiles to adjust OBJS_SRCS_FILTER to control setting of OBJS from SRCS
default R matches precedent, but makefile can add T to avoid subdirs in .OBJDIR

Test Plan

Buildworld ok
plus lib/libbearssl which uses subdirs in SRCS but not in .OBJDIR

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 11579
Build 11932: arc lint + arc unit

Event Timeline

I'm curious what you need this for?

Also you may need to add it to DEPENDOBJS which is just which objects get -M flags at compilation and which ones are expected to have a _.depend.foo.o_ file to be read in. Could save some stats if it makes sense to filter them out.

share/mk/bsd.dep.mk:DEPENDOBJS+=        ${DEPENDSRCS:R:S,$,.o,}

Based on:

share/mk/bsd.dep.mk:DEPENDSRCS= ${SRCS:M*.[cSC]} ${SRCS:M*.cxx} ${SRCS:M*.cpp} ${SRCS:M*.cc}
This revision is now accepted and ready to land.Sep 15 2017, 2:52 AM

I'm curious what you need this for?

New library libbearssl does a reachover build of BearSSL, want to be able to represent the subdirs in SRCS but have no need of subdirs in .OBJDIR

Also you may need to add it to DEPENDOBJS which is just which objects get -M flags at compilation and which ones are expected to have a _.depend.foo.o_ file to be read in. Could save some stats if it makes sense to filter them out.

Thanks will take a look

In D12218#256751, @sjg wrote:

Also you may need to add it to DEPENDOBJS which is just which objects get -M flags at compilation and which ones are expected to have a _.depend.foo.o_ file to be read in. Could save some stats if it makes sense to filter them out.

I took a look at bsd.dep.mk most of it explicitly excludes SRCS with subdirs, and in another case it replaces / with _, so not sure there's anything to touch at all yet.

sjg edited the summary of this revision. (Show Details)
sjg edited the test plan for this revision. (Show Details)

Add bsd.dep.mk

This revision now requires review to proceed.Sep 15 2017, 6:03 AM
This revision is now accepted and ready to land.Sep 15 2017, 3:11 PM
This revision was automatically updated to reflect the committed changes.