Differential D12035

loader.efi: repace XXX with real comments in trap.c
ClosedPublic
Actions

Authored by tsoome on Aug 15 2017, 1:40 PM.

Details

Reviewers

kib

Commits

rS322542: loader.efi: repace XXX with real comments in trap.c

Summary

There are two missing comments marked as XXX in trap.c, fix this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Aug 15 2017, 1:40 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2017, 1:40 PM

kib accepted this revision.Aug 15 2017, 1:56 PM

This revision is now accepted and ready to land.Aug 15 2017, 1:56 PM

Closed by commit rS322542: loader.efi: repace XXX with real comments in trap.c (authored by tsoome). · Explain WhyAug 15 2017, 2:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

loader/

arch/

amd64/

trap.c

14 lines

Diff 32085

View Options

head/sys/boot/efi/loader/arch/amd64/trap.c

Show First 20 Lines • Show All 1,096 Lines • ▼ Show 20 Lines	for (; count > 0; count--) {
}		}

VNASSERT(vp->v_op != NULL, vp,		VNASSERT(vp->v_op != NULL, vp,
("vnlru_free: vnode already reclaimed."));		("vnlru_free: vnode already reclaimed."));
KASSERT((vp->v_iflag & VI_FREE) != 0,		KASSERT((vp->v_iflag & VI_FREE) != 0,
("Removing vnode not on freelist"));		("Removing vnode not on freelist"));
KASSERT((vp->v_iflag & VI_ACTIVE) == 0,		KASSERT((vp->v_iflag & VI_ACTIVE) == 0,
("Mangling active vnode"));		("Mangling active vnode"));
TAILQ_REMOVE(&vnode_free_list, vp, v_actfreelist);

/*		/*
* Don't recycle if our vnode is from different type		* Don't recycle if our vnode is from different type
* of mount point. Note that mp is type-safe, the		* of mount point. Note that mp is type-safe, the
* check does not reach unmapped address even if		* check does not reach unmapped address even if
* vnode is reclaimed.		* vnode is reclaimed.
* Don't recycle if we can't get the interlock without		* Don't recycle if we can't get the interlock without
* blocking.		* blocking.
*/		*/
if ((mnt_op != NULL && (mp = vp->v_mount) != NULL &&		if ((mnt_op != NULL && (mp = vp->v_mount) != NULL &&
mp->mnt_op != mnt_op) \|\| !VI_TRYLOCK(vp)) {		mp->mnt_op != mnt_op) \|\| !VI_TRYLOCK(vp)) {
TAILQ_INSERT_TAIL(&vnode_free_list, vp, v_actfreelist);
continue;		continue;
}		}
VNASSERT((vp->v_iflag & VI_FREE) != 0 && vp->v_holdcnt == 0,		VNASSERT((vp->v_iflag & VI_FREE) != 0 && vp->v_holdcnt == 0,
vp, ("vp inconsistent on freelist"));		vp, ("vp inconsistent on freelist"));

/*		/*
* The clear of VI_FREE prevents activation of the		* The clear of VI_FREE prevents activation of the
* vnode. There is no sense in putting the vnode on		* vnode. There is no sense in putting the vnode on
* the mount point active list, only to remove it		* the mount point active list, only to remove it
* later during recycling. Inline the relevant part		* later during recycling. Inline the relevant part
* of vholdl(), to avoid triggering assertions or		* of vholdl(), to avoid triggering assertions or
* activating.		* activating.
*/		*/
freevnodes--;		freevnodes--;
vp->v_iflag &= ~VI_FREE;
VNODE_REFCOUNT_FENCE_REL();
refcount_acquire(&vp->v_holdcnt);

mtx_unlock(&vnode_free_list_mtx);		mtx_unlock(&vnode_free_list_mtx);
		vholdl(vp);
VI_UNLOCK(vp);		VI_UNLOCK(vp);
vtryrecycle(vp);		vtryrecycle(vp);
/*		/*
* If the recycled succeeded this vdrop will actually free		* If the recycled succeeded this vdrop will actually free
* the vnode. If not it will simply place it back on		* the vnode. If not it will simply place it back on
* the free list.		* the free list.
*/		*/
vdrop(vp);		vdrop(vp);
▲ Show 20 Lines • Show All 4,689 Lines • Show Last 20 Lines

loader.efi: repace XXX with real comments in trap.cClosedPublicActions