Page MenuHomeFreeBSD
Differential D12035

loader.efi: repace XXX with real comments in trap.c
ClosedPublic
Actions

Authored by tsoome on Aug 15 2017, 1:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 10:28 PM
Unknown Object (File)
Thu, Apr 17, 8:55 AM
Unknown Object (File)
Mon, Apr 14, 9:57 PM
Unknown Object (File)
Mon, Apr 14, 8:01 AM
Unknown Object (File)
Mon, Apr 14, 3:45 AM
Unknown Object (File)
Mon, Apr 14, 1:00 AM
Unknown Object (File)
Sun, Apr 13, 10:41 PM
Unknown Object (File)
Feb 17 2025, 12:57 PM
View All 55 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS322542: loader.efi: repace XXX with real comments in trap.c
Summary

There are two missing comments marked as XXX in trap.c, fix this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11090
Build 11474: arc lint + arc unit

Event Timeline

tsoome created this revision.Aug 15 2017, 1:40 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 15 2017, 1:40 PM
kib accepted this revision.Aug 15 2017, 1:56 PM
This revision is now accepted and ready to land.Aug 15 2017, 1:56 PM
Closed by commit rS322542: loader.efi: repace XXX with real comments in trap.c (authored by tsoome). · Explain WhyAug 15 2017, 2:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
boot/
efi/
loader/
arch/
amd64/
14 lines

Diff 32084

View Options

sys/boot/efi/loader/arch/amd64/trap.c

  • This file was added.
.\" Copyright (c) 2018 Emmanuel Vadot <manu@freebsd.org>
.\"
.\" Redistribution and use in source and binary forms, with or without
.\" modification, are permitted provided that the following conditions
.\" are met:
.\" 1. Redistributions of source code must retain the above copyright
.\" notice, this list of conditions and the following disclaimer.
.\" 2. Redistributions in binary form must reproduce the above copyright
.\" notice, this list of conditions and the following disclaimer in the
.\" documentation and/or other materials provided with the distribution.
.\"
.\" THIS SOFTWARE IS PROVIDED BY THE DEVELOPERS ``AS IS'' AND ANY EXPRESS OR
.\" IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
.\" OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
.\" IN NO EVENT SHALL THE DEVELOPERS BE LIABLE FOR ANY DIRECT, INDIRECT,
.\" INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
.\" NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
.\" DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
.\" THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
.\" THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
.\"
.\" $FreeBSD$
.\"
.Dd November 12, 2018
.Dt PWMBUS 9
.Os
.Sh NAME
.Nm pwmbus ,
.Nm pwmbus_attach_bus ,
.Nm PWMBUS_GET_BUS ,
.Nm PWMBUS_CHANNEL_CONFIG ,
.Nm PWMBUS_CHANNEL_GET_CONFIG ,
.Nm PWMBUS_CHANNEL_SET_FLAGS ,
.Nm PWMBUS_CHANNEL_GET_FLAGS ,
.Nm PWMBUS_CHANNEL_ENABLE ,
.Nm PWMBUS_CHANNEL_IS_ENABLED ,
.Nm PWMBUS_CHANNEL_MAX
.Nd PWMBUS methods
.Sh SYNOPSIS
.Cd "device pwm"
.In "pwmbus_if.h"
.Ft device_t
.Fn pwmbus_attach_bus "device_t dev"
.Ft int
.Fn PWMBUS_CHANNEL_CONFIG "device_t bus" "int channel" "uint64_t period" "uint64_t duty"
.Ft int
.Fn PWMBUS_CHANNEL_GET_CONFIG "device_t bus" "int channel" "uint64_t *period" "uint64_t *duty"
.Ft int
.Fn PWMBUS_CHANNEL_SET_FLAGS "device_t bus" "int channel" "uint32_t flags"
.Ft int
.Fn PWMBUS_CHANNEL_GET_FLAGS "device_t bus" "int channel" "uint32_t *flags"
.Ft int
.Fn PWMBUS_CHANNEL_ENABLE "device_t bus" "int channel" "bool enable"
.Ft int
.Fn PWMBUS_CHANNEL_IS_ENABLED "device_t bus" "int channel" "bool *enabled"
.Ft int
.Fn PWMBUS_CHANNEL_MAX "device_t bus" "int channel" "int *nchannel"
.Sh DESCRIPTION
The PWMBUS (Pulse-Width Modulation) interface allows the device driver to register to a global
0mpUnsubmitted
Done
Inline Actions

This paragraph has similar issues to the one from the other manual page reviewed by @bcr.

0mp: This paragraph has similar issues to the one from the other manual page reviewed by @bcr.
bcrUnsubmitted
Done
Inline Actions

This is still the old version? Should be fixing the same issue as above (s/allow device/allows the device/)

bcr: This is still the old version? Should be fixing the same issue as above (s/allow device/allows…
bus so other devices in the kernel can use them in a generic way
.Sh INTERFACE
.Bl -tag -width indent
.It Fn pwmbus_attach_bus "device_t dev"
Attach the pwmbus to the device driver
0mpUnsubmitted
Done
Inline Actions

.Nm pwmbus

0mp: .Nm pwmbus
.It Fn PWMBUS_CHANNEL_CONFIG "device_t bus" "int channel" "uint64_t period" "uint64_t duty"
Configure the period and duty (in nanoseconds) in the pwm controller on the bus for the specified channel.
0mpUnsubmitted
Done
Inline Actions

s/pwm/PWM/

0mp: s/pwm/PWM/
Returns 0 on success or EINVAL is the values are not supported by the controller or
0mpUnsubmitted
Done
Inline Actions

.Er EINVAL

0mp: .Er EINVAL
EBUSY is the PWMBUS controller is in use and doesn't support changing the value on the fly.
.It Fn PWMBUS_CHANNEL_GET_CONFIG "device_t bus" "int channel" "uint64_t *period" "uint64_t *duty"
Get the current configuration of the period and duty for the specified channel.
.It Fn PWMBUS_CHANNEL_SET_FLAGS "device_t bus" "int channel" "uint32_t flags"
Set the flags of the channel (like inverted polarity), if the driver or controller
doesn't support this a default method is used.
.It Fn PWMBUS_CHANNEL_GET_FLAGS "device_t bus" "int channel" "uint32_t *flags"
Get the current flags for the channel, if the driver or controller
doesn't support this, a default method is used.
.It Fn PWMBUS_CHANNEL_ENABLE "device_t bus" "int channel" "bool enable"
Enable the pwm channel.
0mpUnsubmitted
Done
Inline Actions

s/pwm/PWM

0mp: s/pwm/PWM
.It Fn PWMBUS_CHANNEL_ISENABLED "device_t bus" "int channel" "bool *enable"
Test if the pwm channel is enabled.
0mpUnsubmitted
Done
Inline Actions

s/pwm/PWM

0mp: s/pwm/PWM
.It PWMBUS_CHANNEL_MAX "device_t bus" "int channel" "int *nchannel"
Get the maximum number of channel supported by the controller.
.El
.Sh HISTORY
The pwmbus interface first appear in
0mpUnsubmitted
Done
Inline Actions

.Nm pwmbus

0mp: .Nm pwmbus
.Fx 13.0 .
The pwmbus interface and manual page was written by
0mpUnsubmitted
Done
Inline Actions

.Nm pwmbus

0mp: .Nm pwmbus
.An Emmanuel Vadot Aq Mt manu@FreeBSD.org .