DESCRIPTION
Add `__' prefix to the ABI of libmd to avoid name conflicts with libcrypto.
( Related to D2216: Avoid symbol clashes between libmd and libcrypto )
Differential D1542
Add `__' prefix to the ABI of libmd ume on Jan 16 2015, 5:32 AM. Authored by Tags None Referenced Files
Details DESCRIPTIONAdd `__' prefix to the ABI of libmd to avoid name conflicts with libcrypto. ( Related to D2216: Avoid symbol clashes between libmd and libcrypto )
Diff Detail
Event TimelineComment Actions I don't think it is a good idea. There is too much code out there written under assumption that those functions can't fail and original interface emphasizes the intent. *_Init is a little bit trickier because it requires parameter validation, etc. But in our case it still never fails. Comment Actions I think changing API is not good idea. How about the attached patch? It changes function names to avoid conflicts with libcrypto. Comment Actions "__" prefix is reserved and should not be used in the library. If you want to rename the symbols, let's simply rename them, as well as all API consumers. Have you considered adding symbol versioning to libmd? I think it should resolve original install issue -- I assume it to be two shared libraries providing the same symbol. BTW there should be a way to update patch in review, instead of posting link to a file. Comment Actions The use of `__' is intentional, here. It seems you are confusing ABI Comment Actions You would need to bump shlib major. Comment Actions No, we don't need to bump shlib major until removing weak_reference. Comment Actions Gleb, still you against this patch? '__' is reserved for implementation (by POSIX.1-2008), so I think this is correct usage. We already use a lot of these prefix symbols in our libraries. |