[NEW PORT] audio/lvtk: Wraps the LV2 C API and extensions into easy to use C++ classes
ClosedPublic
Actions

Authored by ultima on Aug 12 2017, 8:36 PM.

Details

Reviewers

lifanov
matthew

Commits

rP447921: This toolkit contains libraries that wrap the LV2 C API and extensions into

Summary

This toolkit contains libraries that wrap the LV2 C API and extensions into
easy to use C++ classes. The original work for this was mostly done by
Lars Luthman in lv2-c++-tools.

WWW: https://github.com/lvtk/lvtk

PR\: 221272
Submitted by\: Yuri Victorovich (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ultima created this revision.Aug 12 2017, 8:36 PM

Herald added a subscriber: mat. · View Herald TranscriptAug 12 2017, 8:36 PM

Harbormaster completed remote builds in B11057: Diff 32001.Aug 12 2017, 8:36 PM

lgtm

This revision is now accepted and ready to land.Aug 13 2017, 2:50 PM

Closed by commit rP447921: This toolkit contains libraries that wrap the LV2 C API and extensions into (authored by ultima). · Explain WhyAug 13 2017, 10:34 PM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Aug 14 2017, 1:45 PM

head/audio/lvtk/Makefile
19	That is not 1.2.0: $ git clone https://github.com/lvtk/lvtk.git Cloning into 'lvtk'... cd remote: Counting objects: 2825, done. [...] $ cd lvtk $ git describe --tags 7c0ffdf 1.2.0-23-g7c0ffdf

ultima added inline comments.Aug 14 2017, 4:36 PM

head/audio/lvtk/Makefile
19	Was DISTVERSIONSUFFIX= -23 the proper solution?

mat added inline comments.Aug 16 2017, 3:17 PM

head/audio/lvtk/Makefile
19	Mmm, no, this would not change the version of the port, the idea is to have a version that reflects the fact that it is not 1.2.0. The proper solution is: DISTVERSION= 1.2.0-23 DISTVERSIONSUFFIX= -g7c0ffd And remove the GH_TAGNAME. The `1.2.0-23-g7c0ffdf` can be splitted into `<tag>-<nb commit since tag>-g<short commit hash>`. So the -23 must be in the version of the port, it means that it is after said tag, but it is an artificial number, it cannot really lead back to the commit without specifying the hash. (there can be many branches, out of which one commit each can lead back to the tag after 23 commits.)