Page MenuHomeFreeBSD

[NEW PORT] audio/lvtk: Wraps the LV2 C API and extensions into easy to use C++ classes
ClosedPublic

Authored by ultima on Aug 12 2017, 8:36 PM.
Tags
None
Referenced Files
F87162789: D12013.diff
Sun, Jun 30, 12:26 AM
Unknown Object (File)
Tue, Jun 25, 9:47 PM
Unknown Object (File)
Sun, Jun 2, 5:43 AM
Unknown Object (File)
May 4 2024, 7:10 AM
Unknown Object (File)
May 4 2024, 7:06 AM
Unknown Object (File)
May 4 2024, 7:06 AM
Unknown Object (File)
Apr 29 2024, 10:17 AM
Unknown Object (File)
Apr 19 2024, 12:35 PM
Subscribers

Details

Summary

This toolkit contains libraries that wrap the LV2 C API and extensions into
easy to use C++ classes. The original work for this was mostly done by
Lars Luthman in lv2-c++-tools.

WWW: https://github.com/lvtk/lvtk

PR\: 221272
Submitted by\: Yuri Victorovich (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
looks fine.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 11057
Build 11442: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 13 2017, 2:50 PM
This revision was automatically updated to reflect the committed changes.
head/audio/lvtk/Makefile
19 ↗(On Diff #32022)

That is not 1.2.0:

$ git clone https://github.com/lvtk/lvtk.git
Cloning into 'lvtk'...
cd remote: Counting objects: 2825, done.
[...]
$ cd lvtk
$ git describe --tags 7c0ffdf
1.2.0-23-g7c0ffdf
head/audio/lvtk/Makefile
19 ↗(On Diff #32022)

Was DISTVERSIONSUFFIX= -23 the proper solution?

head/audio/lvtk/Makefile
19 ↗(On Diff #32022)

Mmm, no, this would not change the version of the port, the idea is to have a version that reflects the fact that it is not 1.2.0. The proper solution is:

DISTVERSION= 1.2.0-23
DISTVERSIONSUFFIX= -g7c0ffd

And remove the GH_TAGNAME.

The 1.2.0-23-g7c0ffdf can be splitted into <tag>-<nb commit since tag>-g<short commit hash>. So the -23 must be in the version of the port, it means that it is after said tag, but it is an artificial number, it cannot really lead back to the commit without specifying the hash. (there can be many branches, out of which one commit each can lead back to the tag after 23 commits.)