www/node: Update 8.2.1 -> 8.3.0
- Revert libc++ workaround from r444555, since upstream has fixed the issue differently.
- Refresh patches with 'make makepatch'
Approved by: robak (mentor)
Details
Details
- Reviewers
robak mat - Commits
- rP447673: www/node: Update 8.2.1 -> 8.3.0
$ pwd
/usr/ports/www/node
$ portlint -C
WARN: Makefile: [0]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/etc/make.conf".
0 fatal errors and 2 warnings found.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 10994 Build 11381: arc lint + arc unit
Event Timeline
Comment Actions
Revert changes from r444555, since upstream has solved the issue
differently. Refresh all patches with make makepatch.
| www/node/files/patch-deps_v8_src_arm_cpu-arm.cc | ||
|---|---|---|
| 1–3 | This one did not change, so don't include it. The only changes that warrant a commit to a patch are:
Everything else, like timestamps, or function names after the @@ are comments and do not warrant a commit. I will write this down in the handbook, one day. | |
| www/node/files/patch-deps_v8_src_libsampler_sampler.cc | ||
| 1–3 | This one here, too, is not needed. | |
Comment Actions
Good point. I recall being told essentially the same thing when submitting PRs before getting my commit bit. I will remove the unnecessary deltas.