Page MenuHomeFreeBSD

www/node: Update 8.2.1 -> 8.3.0

Authored by bhughes on Aug 10 2017, 5:57 AM.



www/node: Update 8.2.1 -> 8.3.0

  • Revert libc++ workaround from r444555, since upstream has fixed the issue differently.
  • Refresh patches with 'make makepatch'

Approved by: robak (mentor)

Test Plan

$ pwd
$ portlint -C
WARN: Makefile: [0]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/etc/make.conf".
0 fatal errors and 2 warnings found.

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Revert changes from r444555, since upstream has solved the issue
differently. Refresh all patches with make makepatch.

bhughes edited the test plan for this revision. (Show Details)
1–3 ↗(On Diff #31856)

This one did not change, so don't include it.

The only changes that warrant a commit to a patch are:

  • metadata change, that is, the @@ -w,x +y,z @@ bits
  • changes in the content itself.

Everything else, like timestamps, or function names after the @@ are comments and do not warrant a commit.

I will write this down in the handbook, one day.

1–3 ↗(On Diff #31856)

This one here, too, is not needed.

This revision is now accepted and ready to land.Aug 10 2017, 12:39 PM

Good point. I recall being told essentially the same thing when submitting PRs before getting my commit bit. I will remove the unnecessary deltas.

bhughes edited edge metadata.
bhughes marked an inline comment as done.

Remove unnecessary deltas in files/patch-*

This revision now requires review to proceed.Aug 10 2017, 12:44 PM
This revision was automatically updated to reflect the committed changes.