header.l10n.ent and remove layout
ClosedPublic
Actions

Authored by ygy on Jul 31 2017, 7:28 AM.

Details

Reviewers

rcyu
delphij
kevlo
loader

Commits

rD50662: -Updated header.l10n.ent based on the zh_TW and en_US versions.

Summary

Updated header.l10n.ent based on the zh_TW and en_US versions.

Changed to used layout files from en_US as zh_TW and jp versions are doing that as well. Old local layouts are deleted.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ygy created this revision.Jul 31 2017, 7:28 AM

rcyu accepted this revision.Jul 31 2017, 2:20 PM

This revision is now accepted and ready to land.Jul 31 2017, 2:20 PM

Looks good overall, please fix the few minor nits.

zh_CN.UTF-8/share/xml/header.l10n.ent
5	Please update this to reflect actual revision.
64	Should be zh_CN (It's Ok to reference zh_TW as long as there is no zh_CN translation, but we prefer our translation if they are available).
78	We don't have current translation, please use &enbase; here.
117	Should be "Subversion" here? (Same for zh_TW).

This revision now requires changes to proceed.Aug 4 2017, 11:54 PM

Fixed issues from the review comments.
Did a complete comparison with the newest file in en_US, and updated the version number.

ygy marked 4 inline comments as done.Aug 6 2017, 8:32 AM

ygy added inline comments.Aug 6 2017, 8:38 AM

zh_CN.UTF-8/share/xml/header.l10n.ent
117	A PR with patch reflecting this issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221273

Please see comments inline.

By the way, some entities are merely copies from header.ent but they do not differ, are they really necessary?

zh_CN.UTF-8/share/xml/header.l10n.ent
10	I think enbase should be used here?
14	Please use consistent translation for "Homepage", it should be either all "主页" or "首页" but not both.
15	Since this is the same as the base header.ent, is it necessary?
19	Similar.
24	This should be translated.
25	Ditto.
33	I doubt if this is necessary (similar to earlier duplicated entries that is already present in base header.ent), could you please do some experiments and see if they are actually necessary? (I think overriding header2.word.search value is sufficient).
46	Ditto.

This revision now requires changes to proceed.Aug 6 2017, 8:55 AM

In D11794#246629, @delphij wrote:

Please see comments inline.

By the way, some entities are merely copies from header.ent but they do not differ, are they really necessary?

I got confused and just brought in some changes from header.ent, actually I suspected they are not necessary. Will definitely do experiments to keep only the necessary parts.