Differential D11871

Add some more time-related functions to the LinuxKPI
ClosedPublic
Actions

Authored by markj on Aug 5 2017, 3:15 AM.

Details

Reviewers

• hselasky

Commits

rS322213: Add round_jiffies_up(), local_clock() and __setup_timer() to the LinuxKPI.

Summary

round_jiffies_up*(): just use the existing round_jiffies(), which unconditionally rounds up
local_clock()
__setup_timer(), which takes a flags argument. Allow and ignore TIMER_IRQSAFE since nothing in the LinuxKPI runs in hard interrupt context

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10910
Build 11299: arc lint + arc unit

Event Timeline

markj created this revision.Aug 5 2017, 3:15 AM

Herald added a subscriber: emaste. · View Herald TranscriptAug 5 2017, 3:15 AM

Harbormaster completed remote builds in B10868: Diff 31606.Aug 5 2017, 3:15 AM

markj added a reviewer: • hselasky.Aug 5 2017, 3:16 AM

• hselasky added inline comments.Aug 5 2017, 8:29 AM

sys/compat/linuxkpi/common/include/linux/sched.h
161	Do you need to cast this multiplication?

Cast multiplication, add needed linux/timer.h include and sort includes.

Harbormaster completed remote builds in B10910: Diff 31678.Aug 6 2017, 6:49 PM

markj marked an inline comment as done.Aug 6 2017, 6:49 PM

markj added inline comments.

sys/compat/linuxkpi/common/include/linux/sched.h
161	For architectures that have a 32-bit time_t, I think so.

• hselasky accepted this revision.Aug 7 2017, 11:54 AM

This revision is now accepted and ready to land.Aug 7 2017, 11:54 AM

Closed by commit rS322213: Add round_jiffies_up(), local_clock() and __setup_timer() to the LinuxKPI. (authored by markj). · Explain WhyAug 8 2017, 4:34 AM

This revision was automatically updated to reflect the committed changes.

markj marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

sched.h

15 lines

timer.h

20 lines

Diff 31678

View Options

sys/compat/linuxkpi/common/include/linux/sched.h