mail/roundcube-automatic_addressbook: Update to 0.4.3
ClosedPublic
Actions

Authored by ultima on Aug 6 2017, 6:48 AM.

Details

Reviewers

lifanov
matthew

Commits

rP447576: * Updated to 0.4.3

Summary

Updated to 0.4.3
Cleaned up Makefile to better follow PHB
Provide more details in pkg-message to make installing and upgrading easier

Changelog: https://github.com/sblaisot/automatic_addressbook/compare/0.4.2...0.4.3

PR\: 221148
Submitted by\: Andrej Ebert <andrej@ebert.su> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10887
Build 11277: arc lint + arc unit

Event Timeline

ultima created this revision.Aug 6 2017, 6:48 AM

Herald added a subscriber: mat. · View Herald TranscriptAug 6 2017, 6:48 AM

Harbormaster completed remote builds in B10887: Diff 31643.Aug 6 2017, 6:48 AM

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

ultima edited the summary of this revision. (Show Details)Aug 7 2017, 5:31 PM

ultima edited the summary of this revision. (Show Details)

In D11896#246941, @mat wrote:

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

Is the what not important and just needs the why? or a mix of both?

In D11896#247024, @ultima wrote:

In D11896#246941, @mat wrote:

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

Is the what not important and just needs the why? or a mix of both?

The what is easy to see looking at the diff. The why is lost forever if you do not document it in the commit message.

The idea is that a commit message should be at least 70% why and at most 30% what.

ultima edited the summary of this revision. (Show Details)Aug 7 2017, 11:20 PM

In D11896#247095, @mat wrote:

In D11896#247024, @ultima wrote:

In D11896#246941, @mat wrote:

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

Is the what not important and just needs the why? or a mix of both?

The what is easy to see looking at the diff. The why is lost forever if you do not document it in the commit message.

The idea is that a commit message should be at least 70% why and at most 30% what.