mail/roundcube-automatic_addressbook: Update to 0.4.3

[ultima]

Summary

• Updated to 0.4.3
• Cleaned up Makefile to better follow PHB
• Provide more details in pkg-message to make installing and upgrading easier

Changelog: https://github.com/sblaisot/automatic_addressbook/compare/0.4.2...0.4.3

PR\: 221148
Submitted by\: Andrej Ebert <[e-mail]> (maintainer)
Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

[mat]

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

[ultima]

In D11896#246941, @mat wrote:

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

Is the what not important and just needs the why? or a mix of both?

[mat]

In D11896#247024, @ultima wrote:

In D11896#246941, @mat wrote:

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

Is the what not important and just needs the why? or a mix of both?

The what is easy to see looking at the diff. The why is lost forever if you do not document it in the commit message.

The idea is that a commit message should be at least 70% why and at most 30% what.

[ultima]

In D11896#247095, @mat wrote:

In D11896#247024, @ultima wrote:

In D11896#246941, @mat wrote:

In the summary:

Moved USE_GITHUB to USES section

Is what. What you need to write is why, something like:

Cleanup the Makefile.

Is the what not important and just needs the why? or a mix of both?

The what is easy to see looking at the diff. The why is lost forever if you do not document it in the commit message.

The idea is that a commit message should be at least 70% why and at most 30% what.

I don't think the message is 70% why but it is higher than it was. I'll remember to try and improve on this.

[matthew]