Page MenuHomeFreeBSD
Differential D11864

Fix off by one in calculation of the number of buckets for the pc addresses.
ClosedPublic
Actions

Authored by kib on Aug 4 2017, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 4:52 AM
Unknown Object (File)
Fri, Nov 21, 4:51 AM
Unknown Object (File)
Fri, Nov 21, 4:50 AM
Unknown Object (File)
Fri, Nov 21, 4:48 AM
Unknown Object (File)
Wed, Nov 19, 5:37 AM
Unknown Object (File)
Tue, Nov 18, 8:12 PM
Unknown Object (File)
Fri, Nov 14, 2:23 PM
Unknown Object (File)
Sun, Nov 9, 5:17 AM
View All 77 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rS322059: Fix off by one in calculation of the number of buckets for the pc
Summary

This issue caused the assertion at the line 498 to be triggered:

	bucket = (cc[0] - map->ppm_lowpc) / FUNCTION_ALIGNMENT;
	assert(bucket < pgf->pgf_nbuckets);

when cc value appears at the top of the image.

I triggered it with the pmcstat -R log -g.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Aug 4 2017, 1:50 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 4 2017, 1:50 PM
markj accepted this revision.Aug 4 2017, 5:20 PM
This revision is now accepted and ready to land.Aug 4 2017, 5:20 PM
Closed by commit rS322059: Fix off by one in calculation of the number of buckets for the pc (authored by kib). · Explain WhyAug 4 2017, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
pmcstat/
4 lines

Diff 31594

View Options

head/usr.sbin/pmcstat/pmcpl_gprof.c

Loading...