Page MenuHomeFreeBSD

Mk/Uses/shebangfix.mk: Fix SHEBANG_FILES to use find(1)
ClosedPublic

Authored by feld on Aug 3 2017, 7:16 PM.
Tags
None
Referenced Files
F87322271: D11853.id31739.diff
Mon, Jul 1, 6:29 PM
F87322168: D11853.id31539.diff
Mon, Jul 1, 6:28 PM
Unknown Object (File)
Sun, Jun 30, 4:05 PM
Unknown Object (File)
Sun, Jun 30, 3:53 PM
Unknown Object (File)
Sun, Jun 30, 2:58 PM
Unknown Object (File)
Sat, Jun 29, 3:00 PM
Unknown Object (File)
Fri, Jun 21, 12:10 AM
Unknown Object (File)
Fri, Jun 21, 12:06 AM
Subscribers
None

Details

Summary

Ports like net/vmware-vsphere-cli use SHEBANG_FILES with globs like so:

SHEBANG_FILES= bin/* ...

As of FreeBSD 11.??? sed has changed and errors if attempted on non-file objects. In
the case of the cited port there are many other files in the bin/
directory which are symlinks for compatibility with old scripts. This
causes the port patching to fail.

Changing the SHEBANG_FILES logic to use find(1) like SHEBANG_REGEX and
SHEBANG_GLOB seems to be a sane solution with no negative impact.

Test Plan

exp-run?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10847
Build 11239: arc lint + arc unit

Event Timeline

This looks like a good idea. An exp-run may be needed though, there are strange things happening in SHEBANG_FILES.

This revision was automatically updated to reflect the committed changes.