Page MenuHomeFreeBSD

Mk/Uses/shebangfix.mk: Fix SHEBANG_FILES to use find(1)
ClosedPublic

Authored by feld on Aug 3 2017, 7:16 PM.
Tags
None
Referenced Files
F106176622: D11853.diff
Thu, Dec 26, 4:00 PM
Unknown Object (File)
Sun, Dec 8, 11:31 PM
Unknown Object (File)
Thu, Nov 28, 11:18 PM
Unknown Object (File)
Wed, Nov 27, 6:42 AM
Unknown Object (File)
Nov 24 2024, 7:52 AM
Unknown Object (File)
Nov 19 2024, 9:22 PM
Unknown Object (File)
Oct 20 2024, 3:55 PM
Unknown Object (File)
Oct 3 2024, 4:11 PM
Subscribers
None

Details

Summary

Ports like net/vmware-vsphere-cli use SHEBANG_FILES with globs like so:

SHEBANG_FILES= bin/* ...

As of FreeBSD 11.??? sed has changed and errors if attempted on non-file objects. In
the case of the cited port there are many other files in the bin/
directory which are symlinks for compatibility with old scripts. This
causes the port patching to fail.

Changing the SHEBANG_FILES logic to use find(1) like SHEBANG_REGEX and
SHEBANG_GLOB seems to be a sane solution with no negative impact.

Test Plan

exp-run?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks like a good idea. An exp-run may be needed though, there are strange things happening in SHEBANG_FILES.

This revision was automatically updated to reflect the committed changes.