Details
- Reviewers
wblock bcr - Commits
- rD50627: Rewrite the symlink bits and introduce RLN.
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 10834 Build 11226: arc lint + arc unit
Event Timeline
A few textual corrections, nothing major.
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 86 | I would stop the sentence after the {PREFIX}, to have less commas in a sentence (I love using commas myself, but the sentences get too long and difficult). Having smaller sentences helps to understand the two cases here. | |
| 87 | You would use "on the other hand" only if you previously wrote "on the one hand". I would replace it with "In the other case". | |
| 125 | here, I would just use "however" instead of "on the other hand". | |
A small nit, then it's perfect.
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 87 | It's "In the other case", not "On the other case". | |
| 88 | Here, I would not stop the sentence, just remove the commas and the sentence stop after the </filename>. The full sentence should read: In the other case, if one or both of the paths are outside of <filename>${PREFIX}</filename> use <command>${LN} -s</command> and only prepend <filename>${STAGEDIR}</filename> to the target's path. | |