Page MenuHomeFreeBSD
Differential D11660

date: avoid crash on invalid time
ClosedPublic
Actions

Authored by emaste on Jul 19 2017, 6:08 PM.
Tags
None
Referenced Files
F108394145: D11660.id31001.diff
Fri, Jan 24, 10:43 AM
F108394015: D11660.id30975.diff
Fri, Jan 24, 10:42 AM
Unknown Object (File)
Sat, Dec 28, 9:43 AM
Unknown Object (File)
Dec 23 2024, 6:40 AM
Unknown Object (File)
Dec 23 2024, 1:58 AM
Unknown Object (File)
Dec 13 2024, 12:54 AM
Unknown Object (File)
Nov 18 2024, 8:55 PM
Unknown Object (File)
Nov 18 2024, 6:52 PM
View All 96 Files
Subscribers
None

Details

Reviewers
cem
kevans
Commits
rS321293: date: avoid crash on invalid time
Summary

localtime(3) returns NULL when passed an invalid time_t but date(1) previously did not handle it. Exit with an error in that case.

PR:             220828
Reported by:    Vinícius Zavam

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Jul 19 2017, 6:08 PM
cem added inline comments.Jul 19 2017, 7:23 PM
bin/date/date.c
177–180 ↗(On Diff #30966)

This changes the behavior of the code in the success case. Previously we copied the struct tm and modified the local copy. Now we're modifying whatever localtime() gave us, which I suspect is some global storage?

emaste added inline comments.Jul 19 2017, 7:43 PM
bin/date/date.c
177–180 ↗(On Diff #30966)

Yes. Note that setthetime() already modifies the returned struct tm.

cem added inline comments.Jul 19 2017, 7:47 PM
bin/date/date.c
169 ↗(On Diff #30966)

This path can also dereference the pointer returned from localtime() without checking for NULL.

177–180 ↗(On Diff #30966)

Ok.

214–215 ↗(On Diff #30966)

(See here.)

emaste updated this revision to Diff 30973.Jul 19 2017, 8:03 PM

check an additional localtime for NULL return

cem added inline comments.Jul 19 2017, 8:07 PM
bin/date/date.c
215 ↗(On Diff #30973)

Syntax seems wrong and ld not lt.

emaste updated this revision to Diff 30975.Jul 19 2017, 8:12 PM

correct retypeo from previous upload

cem accepted this revision.Jul 19 2017, 8:23 PM
This revision is now accepted and ready to land.Jul 19 2017, 8:23 PM
kevans accepted this revision.Jul 20 2017, 3:25 PM
Closed by commit rS321293: date: avoid crash on invalid time (authored by emaste). · Explain WhyJul 20 2017, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
bin/
date/
12 lines

Diff 31001

View Options

head/bin/date/date.c

Loading...