Page MenuHomeFreeBSD

Improved error messages when *.txz checksum failed during installation
ClosedPublic

Authored by ygy on Jul 18 2017, 7:34 PM.
Tags
None
Referenced Files
F110291678: D11641.id30923.diff
Sun, Feb 16, 8:28 AM
Unknown Object (File)
Mon, Feb 10, 9:38 AM
Unknown Object (File)
Wed, Jan 29, 5:59 AM
Unknown Object (File)
Thu, Jan 23, 11:15 PM
Unknown Object (File)
Mon, Jan 20, 2:31 AM
Unknown Object (File)
Sun, Jan 19, 2:31 PM
Unknown Object (File)
Sat, Jan 18, 7:04 AM
Unknown Object (File)
Sat, Jan 18, 5:38 AM
Subscribers
None

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

usr.sbin/bsdinstall/scripts/checksum
35

This committed as part of rS321178

66

usual sh style puts the individual case entries aligned with case

68

Maybe add "Please check for a newer snapshot." -- @gjb does that sound reasonable?

usr.sbin/bsdinstall/scripts/checksum
66

My vim auto-indent script does the same indentation style as in this diff, which I tend to prefer. We do not have a hard-written style(9) for sh(1) scripts that I can find.

68

Yes.

usr.sbin/bsdinstall/scripts/checksum
66

But this indentation style is not consistent with the rest of bsdinstall

usr.sbin/bsdinstall/scripts/checksum
66

If for consistency in bsdinstall(8), then ok.

usr.sbin/bsdinstall/scripts/checksum
66

fwiw the no-extra-indent style is nearly universal in the src tree (in bin/usr.bin/sbin/usr.sbin)

Updated based on review

ygy marked 8 inline comments as done.Jul 19 2017, 3:42 AM

Pulled from upstream to reflect whitespace fix from another commit

usr.sbin/bsdinstall/scripts/checksum
65–66

One small improvement, we should be able to avoid the extra invocation (sed) and just use *-ALPHA*|*-CURRENT|*-STABLE|*-PRERELEASE) in the case statement.

This revision was automatically updated to reflect the committed changes.