Page MenuHomeFreeBSD

Improved error messages when *.txz checksum failed during installation
ClosedPublic

Authored by ygy on Jul 18 2017, 7:34 PM.
Tags
None
Referenced Files
F147478549: D11641.diff
Wed, Mar 11, 7:52 AM
F147448293: D11641.diff
Wed, Mar 11, 2:48 AM
Unknown Object (File)
Tue, Mar 10, 8:53 PM
Unknown Object (File)
Sun, Mar 8, 5:15 AM
Unknown Object (File)
Thu, Mar 5, 5:44 AM
Unknown Object (File)
Thu, Mar 5, 5:32 AM
Unknown Object (File)
Feb 7 2026, 7:05 PM
Unknown Object (File)
Feb 3 2026, 10:15 PM
Subscribers
None

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

usr.sbin/bsdinstall/scripts/checksum
35

This committed as part of rS321178

66

usual sh style puts the individual case entries aligned with case

68

Maybe add "Please check for a newer snapshot." -- @gjb does that sound reasonable?

usr.sbin/bsdinstall/scripts/checksum
66

My vim auto-indent script does the same indentation style as in this diff, which I tend to prefer. We do not have a hard-written style(9) for sh(1) scripts that I can find.

68

Yes.

usr.sbin/bsdinstall/scripts/checksum
66

But this indentation style is not consistent with the rest of bsdinstall

usr.sbin/bsdinstall/scripts/checksum
66

If for consistency in bsdinstall(8), then ok.

usr.sbin/bsdinstall/scripts/checksum
66

fwiw the no-extra-indent style is nearly universal in the src tree (in bin/usr.bin/sbin/usr.sbin)

Updated based on review

ygy marked 8 inline comments as done.Jul 19 2017, 3:42 AM

Pulled from upstream to reflect whitespace fix from another commit

usr.sbin/bsdinstall/scripts/checksum
65–75

One small improvement, we should be able to avoid the extra invocation (sed) and just use *-ALPHA*|*-CURRENT|*-STABLE|*-PRERELEASE) in the case statement.

This revision was automatically updated to reflect the committed changes.