Page MenuHomeFreeBSD
Differential D11533

Add nsecs_to_jiffies64() and jiffies_to_{nsecs,usecs}().
ClosedPublic
Actions

Authored by markj on Jul 8 2017, 7:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 22, 6:35 AM
Unknown Object (File)
Sat, Feb 22, 1:38 AM
Unknown Object (File)
Sat, Feb 22, 12:54 AM
Unknown Object (File)
Sat, Feb 22, 12:06 AM
Unknown Object (File)
Fri, Feb 21, 10:00 PM
Unknown Object (File)
Fri, Feb 21, 9:22 PM
Unknown Object (File)
Mon, Feb 17, 1:07 PM
Unknown Object (File)
Thu, Feb 13, 1:15 AM
View All 61 Files
Subscribers
emaste

Details

Reviewers
• hselasky
Commits
rS320956: Add some functions to jiffies.h.
Summary

Fix style in related functions.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10411
Build 10821: arc lint + arc unit

Event Timeline

markj created this revision.Jul 8 2017, 7:01 PM
Herald added a subscriber: emaste. · View Herald TranscriptJul 8 2017, 7:01 PM
Harbormaster completed remote builds in B10397: Diff 30586.Jul 8 2017, 7:01 PM
markj added a reviewer: • hselasky.Jul 8 2017, 7:02 PM
• hselasky added inline comments.Jul 8 2017, 9:31 PM
sys/compat/linuxkpi/common/include/linux/jiffies.h
100

These max checks are not sufficient for very large input values. You should also verify that the multiplication does not exceed 64-bits!

const uint64_t nsec_max = -1ULL / (uint64_t)hz;
if (nsec > nsec_max)
nsec = nsec_max;
117

passed jiffies argument should be "int" to avoid problems!

markj updated this revision to Diff 30612.Jul 9 2017, 10:32 PM
  • Address review comments.
Harbormaster completed remote builds in B10411: Diff 30612.Jul 9 2017, 10:32 PM
• hselasky added inline comments.Jul 10 2017, 7:55 PM
sys/compat/linuxkpi/common/include/linux/jiffies.h
99

Can you add this check to the msecs_to_jiffies and usecs_to_jiffies aswell?

• hselasky added inline comments.Jul 10 2017, 8:06 PM
sys/compat/linuxkpi/common/include/linux/jiffies.h
117

Do you need to cast j to (uint64_t) ??

markj updated this revision to Diff 30656.Jul 11 2017, 10:32 PM

Address review comments.

Harbormaster completed remote builds in B10435: Diff 30656.Jul 11 2017, 10:32 PM
• hselasky added inline comments.Jul 12 2017, 7:53 AM
sys/compat/linuxkpi/common/include/linux/jiffies.h
120

(uint64_t)(unsigned int)j ???

We don't like negative times??

Same below. Else the patch looks OK.

markj added inline comments.Jul 13 2017, 6:27 PM
sys/compat/linuxkpi/common/include/linux/jiffies.h
99

Done.

120

Sorry, that was stupid. :(

Thanks for the review.

Closed by commit rS320956: Add some functions to jiffies.h. (authored by markj). · Explain WhyJul 13 2017, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
51 lines

Diff 30612

View Options

sys/compat/linuxkpi/common/include/linux/jiffies.h

Loading...