Fix build on 11.0 and later due to missing libpcap header file
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 10294 Build 10712: arc lint + arc unit
Event Timeline
Comment Actions
I find it weird to include header files like that, newer version of libcap does not provide pcap-int.h, it is probably because it has been replaced by something, there might be a better approach to address this, I'll think about it and come back to you
Comment Actions
Turns out there was a much simpler solution for this build failure. By simply removing reference to "pcap-int.h" (which was not used at all) now this port builds on 10.x, 11.x and 12x just fine.
Comment Actions
Unbreak on 11.x+ by removing reference to unused header file.
Also fixed an issue with creating RAW sockets which caused failure when tracing TCP/UDP (reported by Andrew Wu <yauhwawu@gmail.com>)
| net/lft/files/patch-lft__types.h | ||
|---|---|---|
| 7 | Maybe just add a && !defined(FreeBSD) which will be less intrusive | |
| net/lft/files/patch-lft__icmptrace.c | ||
|---|---|---|
| 8 ↗ | (On Diff #30394) | Instead of changing this one, it seems to me more apropriate to modify lft_lib.h line 280 to also add a && !defined(FreeBSD) |
| net/lft/files/patch-lft__lib.c | ||
| 8 ↗ | (On Diff #30394) | The change in lft_lib.h should also make that patch obsolete (needs testing) |
Comment Actions
Improve the logic when detecting when whether or not we should reverse byte order for ip_len and ip_off.
| net/lft/files/patch-lft__icmptrace.c | ||
|---|---|---|
| 8 ↗ | (On Diff #30394) | True. I just adjusted the logic to disable SCREWED_IP_LEN flag if it is being built on FreeBSD so that byte order reversal will be done appropriately. |