Paths

Table of Contentst

Differential D11405

devel/leiningen: Debashify
ClosedPublic
Actions

Authored by tobik on Jun 29 2017, 3:26 PM.

Tags

None

Referenced Files

	F163325766: D11405.id30210.diff
	Wed, Jul 22, 3:35 AM

	Unknown Object (File)
	Sun, Jul 19, 1:48 PM

	Unknown Object (File)
	Sat, Jul 18, 2:29 AM

	Unknown Object (File)
	Fri, Jul 17, 12:45 PM

	Unknown Object (File)
	Thu, Jul 2, 3:42 PM

	Unknown Object (File)
	Wed, Jul 1, 10:27 PM

	Unknown Object (File)
	Sat, Jun 27, 7:41 PM

	Unknown Object (File)
	Mon, Jun 22, 10:22 PM

Subscribers

None

Details

Reviewers

lme
mat

Commits

rP444653: - Debashify with a little bit of dark magic and use /bin/sh for lein

Summary

- Debashify and use /bin/sh for lein
- Remove pkg-message with outdated advice
- Add LICENSE_FILE

  Approved by:	??? (mentor)
  Differential Revision:	https://reviews.freebsd.org/D?????

Test Plan

poudriere testport 11.0/amd64 ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10189
Build 10610: arc lint + arc unit

Event Timeline

tobik created this revision.Jun 29 2017, 3:26 PM

mat added inline comments.Jun 29 2017, 3:44 PM

devel/leiningen/Makefile
6–8	You should remove all the `:source1` related bits, they are also generated by `USE_GITHUB`. So you end up having the distfile twice, it is the reason you get it twice when you run `make makesum`.
30	This should be ${JAVAJARDIR}/leiningen.jar

Remove :source1 and fix PLIST_FILES

Harbormaster completed remote builds in B10189: Diff 30210.Jun 29 2017, 3:55 PM

Revert distinfo change

mat accepted this revision.Jun 29 2017, 4:27 PM

mat added inline comments.

devel/leiningen/Makefile
36–41	This feels a bit like dark magic :-)

This revision is now accepted and ready to land.Jun 29 2017, 4:27 PM

Closed by commit rP444653: - Debashify with a little bit of dark magic and use /bin/sh for lein (authored by tobik). · Explain WhyJun 29 2017, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

devel/

leiningen/

17 lines

6 lines

Diff 30210

devel/leiningen/Makefile

Loading...

devel/leiningen/distinfo

Loading...

devel/leiningen/pkg-message

Loading...