Details

Reviewers

Commits

rP444164: devel/py-pytest-timeout: Update to 1.2.0

Summary

Proposed commit log message:

devel/py-pytest-timeout: Update to 1.2.0

- Add NO_ARCH
- Add regression test

Reviewed_by: koobs
Approved by: koobs (ports)
Differential_Revision: D10676

Test Plan

portlint: OK (WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.)
testport: OK (poudriere: 1200030, armv6, '', python2.7 tested)
unittest: OK (30 passed, 1 skipped)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10043
Build 10469: arc lint + arc unit

Event Timeline

loader created this revision.May 11 2017, 4:23 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 11 2017, 4:23 AM

Harbormaster completed remote builds in B9187: Diff 28224.May 11 2017, 4:23 AM

add USE_PYTHON=concurrent

Harbormaster completed remote builds in B9851: Diff 29555.Jun 13 2017, 5:04 PM

loader edited the summary of this revision. (Show Details)Jun 13 2017, 5:06 PM

loader edited the test plan for this revision. (Show Details)

loader retitled this revision from devel/py-pytest-timeout: update to 1.2.0 to devel/py-pytest-timeout: Update to 1.2.0.

koobs requested changes to this revision.Jun 20 2017, 10:54 AM

koobs added inline comments.

devel/py-pytest-timeout/Makefile
17	As far as I'm aware, `:=` can result in unintended *_DEPENDS values. It has been recommended in the past to just duplicate TEST_DEPENDS entries ala: RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>=2.8.0:devel/py-pytest TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>=2.8.0:devel/py-pytest
26	As far as I'm aware pytest correctly sets up the PYTHONPATH to be the directory within which the tests are run. Id look at why this is required (and try to remove it) as it may be indicative of incorrectly running/invoking the tests

This revision now requires changes to proceed.Jun 20 2017, 10:54 AM

duplicate TEST_DEPENDS

Harbormaster completed remote builds in B10013: Diff 29864.Jun 20 2017, 5:33 PM

loader marked an inline comment as done.Jun 20 2017, 5:35 PM

loader edited the test plan for this revision. (Show Details)Jun 20 2017, 5:48 PM

loader added inline comments.Jun 20 2017, 6:00 PM

devel/py-pytest-timeout/Makefile
26	It runs tests in new subprocesses like this, most of them will fail if the port is not installed yet. pytest tries to reads the entry points in ${PYTHON_SITELIBDIR} to load the plugins. /usr/local/bin/python2.7 /usr/local/lib/python2.7/site-packages/pytest.py --basetemp=/tmp/pytest-of-root/pytest-1/testdir/test_fix_setup5/runpytest-0 --timeout=1 --timeout_method=thread