Page MenuHomeFreeBSD
Differential D1411

Link lib/libc/c063 tests to the build.
ClosedPublic
Actions

Authored by jilles on Jan 2 2015, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 12:08 PM
Unknown Object (File)
Mon, Apr 14, 7:33 AM
Unknown Object (File)
Mon, Apr 14, 5:58 AM
Unknown Object (File)
Mon, Apr 14, 5:54 AM
Unknown Object (File)
Mon, Apr 14, 5:42 AM
Unknown Object (File)
Fri, Apr 11, 2:44 PM
Unknown Object (File)
Mar 8 2025, 11:49 AM
Unknown Object (File)
Feb 20 2025, 2:08 AM
View All Files
Subscribers
None

Details

Reviewers
ngie
jmmv
Commits
rS276590: Link lib/libc/c063 tests to the build.
Summary

Some files lack required #include <sys/stat.h>.

The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with
faccessat(), which is not specified by POSIX.1-2008.

Test Plan

buildworld and installworld, kyua test in /usr/tests/lib/libc/c063.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jilles updated this revision to Diff 2950.Jan 2 2015, 1:26 PM
jilles retitled this revision from to Link lib/libc/c063 tests to the build..
jilles updated this object.
jilles edited the test plan for this revision. (Show Details)
jilles added reviewers: ngie, jmmv.
ngie edited edge metadata.Jan 2 2015, 8:07 PM

Thanks! Forgot to complete this..

contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c
43 ↗(On Diff #2950)

Please put these if #ifdef FreeBSD #endif blocks so I don't forget to upstream them to NetBSD..

ngie added a comment.Jan 2 2015, 8:09 PM

"The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with
faccessat(), which is not specified by POSIX.1-2008."

The testcase should either be #ifdef NetBSD'ed out, or have a block like this added to it:

#ifdef __FreeBSD__
atf_tc_expect_fail("Depends on non-standard behavior not mentioned in POSIX.1-2008");
#endif
jilles updated this revision to Diff 2964.Jan 2 2015, 10:28 PM
jilles edited edge metadata.

Apply changes requested by ngie. 'kyua test' in c063/ is happy now.

ngie accepted this revision.Jan 2 2015, 10:43 PM
ngie edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 10:43 PM
jilles closed this revision.Jan 2 2015, 10:49 PM
jilles updated this revision to Diff 2965.

Closed by commit rS276590 (authored by @jilles).

Revision Contents
Changeset List

PathSize
head/
contrib/
netbsd-tests/
lib/
libc/
c063/
3 lines
3 lines
3 lines
3 lines
lib/
libc/
tests/
c063/
30 lines

Diff 2965

View Options

head/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDE4_WORKSPACE_VERSION= 4.11.21 KDE4_WORKSPACE_VERSION= 4.11.21
KDE4_KDEPIM_VERSION?= 4.14.10 KDE4_KDEPIM_VERSION?= 4.14.10
# Applications version for the kde4-applications. # Applications version for the kde4-applications.
KDE4_APPLICATIONS_BRANCH?= Attic KDE4_APPLICATIONS_BRANCH?= Attic
KDE4_APPLICATIONS_VERSION?= 15.04.3 KDE4_APPLICATIONS_VERSION?= 15.04.3
KDE4_BRANCH?= stable KDE4_BRANCH?= stable
# Current KDE desktop. # Current KDE desktop.
KDE_FRAMEWORKS_VERSION?= 5.30.0 KDE_FRAMEWORKS_VERSION?= 5.31.0
KDE_FRAMEWORKS_BRANCH?= stable KDE_FRAMEWORKS_BRANCH?= stable
# Current KDE applications. # Current KDE applications.
KDE_APPLICATIONS_VERSION?= 16.12.0 KDE_APPLICATIONS_VERSION?= 16.12.0
KDE_APPLICATIONS_BRANCH?= stable KDE_APPLICATIONS_BRANCH?= stable
# Upstream moves old software to Attic/. Specify the newest applications release there. # Upstream moves old software to Attic/. Specify the newest applications release there.
# Only the major version is used for the comparison. # Only the major version is used for the comparison.
_KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3 _KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3
▲ Show 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
# Porting Aids frameworks provide code and utilities to ease the transition from # Porting Aids frameworks provide code and utilities to ease the transition from
# kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework, # kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework,
# new projects should avoid using these libraries. # new projects should avoid using these libraries.
_USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross _USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross
# These are weird items: not officially released as Frameworks, but # These are weird items: not officially released as Frameworks, but
# required by them (and from KDE). # required by them (and from KDE).
# - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui # - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui
_USE_FRAMEWORKS_EXTRA= kirigami _USE_FRAMEWORKS_EXTRA= kirigami kirigami2
_USE_FRAMEWORKS_ALL= ecm \ _USE_FRAMEWORKS_ALL= ecm \
${_USE_FRAMEWORKS_TIER1} \ ${_USE_FRAMEWORKS_TIER1} \
${_USE_FRAMEWORKS_TIER2} \ ${_USE_FRAMEWORKS_TIER2} \
${_USE_FRAMEWORKS_TIER3} \ ${_USE_FRAMEWORKS_TIER3} \
${_USE_FRAMEWORKS_TIER4} \ ${_USE_FRAMEWORKS_TIER4} \
${_USE_FRAMEWORKS_PORTING} \ ${_USE_FRAMEWORKS_PORTING} \
${_USE_FRAMEWORKS_EXTRA} ${_USE_FRAMEWORKS_EXTRA}
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines
kimageformats_PORT= graphics/kf5-kimageformats kimageformats_PORT= graphics/kf5-kimageformats
kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so
kimageformats_TYPE= run kimageformats_TYPE= run
kio_PORT= devel/kf5-kio kio_PORT= devel/kf5-kio
kio_LIB= libKF5KIOCore.so kio_LIB= libKF5KIOCore.so
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami_PORT= x11-toolkits/kirigami kirigami_PORT= x11-toolkits/kirigami
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami2_PORT= x11-toolkits/kirigami2
kirigami2_PATH= ${QT_QMLDIR}/org/kde/kirigami.2/libkirigamiplugin.so
kross_PORT= lang/kf5-kross kross_PORT= lang/kf5-kross
kross_LIB= libKF5KrossCore.so kross_LIB= libKF5KrossCore.so
mediaplayer_PORT= multimedia/kf5-kmediaplayer mediaplayer_PORT= multimedia/kf5-kmediaplayer
mediaplayer_LIB= libKF5MediaPlayer.so.5 mediaplayer_LIB= libKF5MediaPlayer.so.5
newstuff_PORT= devel/kf5-knewstuff newstuff_PORT= devel/kf5-knewstuff
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines
View Options

head/contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDE4_WORKSPACE_VERSION= 4.11.21 KDE4_WORKSPACE_VERSION= 4.11.21
KDE4_KDEPIM_VERSION?= 4.14.10 KDE4_KDEPIM_VERSION?= 4.14.10
# Applications version for the kde4-applications. # Applications version for the kde4-applications.
KDE4_APPLICATIONS_BRANCH?= Attic KDE4_APPLICATIONS_BRANCH?= Attic
KDE4_APPLICATIONS_VERSION?= 15.04.3 KDE4_APPLICATIONS_VERSION?= 15.04.3
KDE4_BRANCH?= stable KDE4_BRANCH?= stable
# Current KDE desktop. # Current KDE desktop.
KDE_FRAMEWORKS_VERSION?= 5.30.0 KDE_FRAMEWORKS_VERSION?= 5.31.0
KDE_FRAMEWORKS_BRANCH?= stable KDE_FRAMEWORKS_BRANCH?= stable
# Current KDE applications. # Current KDE applications.
KDE_APPLICATIONS_VERSION?= 16.12.0 KDE_APPLICATIONS_VERSION?= 16.12.0
KDE_APPLICATIONS_BRANCH?= stable KDE_APPLICATIONS_BRANCH?= stable
# Upstream moves old software to Attic/. Specify the newest applications release there. # Upstream moves old software to Attic/. Specify the newest applications release there.
# Only the major version is used for the comparison. # Only the major version is used for the comparison.
_KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3 _KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3
▲ Show 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
# Porting Aids frameworks provide code and utilities to ease the transition from # Porting Aids frameworks provide code and utilities to ease the transition from
# kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework, # kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework,
# new projects should avoid using these libraries. # new projects should avoid using these libraries.
_USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross _USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross
# These are weird items: not officially released as Frameworks, but # These are weird items: not officially released as Frameworks, but
# required by them (and from KDE). # required by them (and from KDE).
# - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui # - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui
_USE_FRAMEWORKS_EXTRA= kirigami _USE_FRAMEWORKS_EXTRA= kirigami kirigami2
_USE_FRAMEWORKS_ALL= ecm \ _USE_FRAMEWORKS_ALL= ecm \
${_USE_FRAMEWORKS_TIER1} \ ${_USE_FRAMEWORKS_TIER1} \
${_USE_FRAMEWORKS_TIER2} \ ${_USE_FRAMEWORKS_TIER2} \
${_USE_FRAMEWORKS_TIER3} \ ${_USE_FRAMEWORKS_TIER3} \
${_USE_FRAMEWORKS_TIER4} \ ${_USE_FRAMEWORKS_TIER4} \
${_USE_FRAMEWORKS_PORTING} \ ${_USE_FRAMEWORKS_PORTING} \
${_USE_FRAMEWORKS_EXTRA} ${_USE_FRAMEWORKS_EXTRA}
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines
kimageformats_PORT= graphics/kf5-kimageformats kimageformats_PORT= graphics/kf5-kimageformats
kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so
kimageformats_TYPE= run kimageformats_TYPE= run
kio_PORT= devel/kf5-kio kio_PORT= devel/kf5-kio
kio_LIB= libKF5KIOCore.so kio_LIB= libKF5KIOCore.so
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami_PORT= x11-toolkits/kirigami kirigami_PORT= x11-toolkits/kirigami
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami2_PORT= x11-toolkits/kirigami2
kirigami2_PATH= ${QT_QMLDIR}/org/kde/kirigami.2/libkirigamiplugin.so
kross_PORT= lang/kf5-kross kross_PORT= lang/kf5-kross
kross_LIB= libKF5KrossCore.so kross_LIB= libKF5KrossCore.so
mediaplayer_PORT= multimedia/kf5-kmediaplayer mediaplayer_PORT= multimedia/kf5-kmediaplayer
mediaplayer_LIB= libKF5MediaPlayer.so.5 mediaplayer_LIB= libKF5MediaPlayer.so.5
newstuff_PORT= devel/kf5-knewstuff newstuff_PORT= devel/kf5-knewstuff
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines
View Options

head/contrib/netbsd-tests/lib/libc/c063/t_fchownat.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDE4_WORKSPACE_VERSION= 4.11.21 KDE4_WORKSPACE_VERSION= 4.11.21
KDE4_KDEPIM_VERSION?= 4.14.10 KDE4_KDEPIM_VERSION?= 4.14.10
# Applications version for the kde4-applications. # Applications version for the kde4-applications.
KDE4_APPLICATIONS_BRANCH?= Attic KDE4_APPLICATIONS_BRANCH?= Attic
KDE4_APPLICATIONS_VERSION?= 15.04.3 KDE4_APPLICATIONS_VERSION?= 15.04.3
KDE4_BRANCH?= stable KDE4_BRANCH?= stable
# Current KDE desktop. # Current KDE desktop.
KDE_FRAMEWORKS_VERSION?= 5.30.0 KDE_FRAMEWORKS_VERSION?= 5.31.0
KDE_FRAMEWORKS_BRANCH?= stable KDE_FRAMEWORKS_BRANCH?= stable
# Current KDE applications. # Current KDE applications.
KDE_APPLICATIONS_VERSION?= 16.12.0 KDE_APPLICATIONS_VERSION?= 16.12.0
KDE_APPLICATIONS_BRANCH?= stable KDE_APPLICATIONS_BRANCH?= stable
# Upstream moves old software to Attic/. Specify the newest applications release there. # Upstream moves old software to Attic/. Specify the newest applications release there.
# Only the major version is used for the comparison. # Only the major version is used for the comparison.
_KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3 _KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3
▲ Show 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
# Porting Aids frameworks provide code and utilities to ease the transition from # Porting Aids frameworks provide code and utilities to ease the transition from
# kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework, # kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework,
# new projects should avoid using these libraries. # new projects should avoid using these libraries.
_USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross _USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross
# These are weird items: not officially released as Frameworks, but # These are weird items: not officially released as Frameworks, but
# required by them (and from KDE). # required by them (and from KDE).
# - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui # - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui
_USE_FRAMEWORKS_EXTRA= kirigami _USE_FRAMEWORKS_EXTRA= kirigami kirigami2
_USE_FRAMEWORKS_ALL= ecm \ _USE_FRAMEWORKS_ALL= ecm \
${_USE_FRAMEWORKS_TIER1} \ ${_USE_FRAMEWORKS_TIER1} \
${_USE_FRAMEWORKS_TIER2} \ ${_USE_FRAMEWORKS_TIER2} \
${_USE_FRAMEWORKS_TIER3} \ ${_USE_FRAMEWORKS_TIER3} \
${_USE_FRAMEWORKS_TIER4} \ ${_USE_FRAMEWORKS_TIER4} \
${_USE_FRAMEWORKS_PORTING} \ ${_USE_FRAMEWORKS_PORTING} \
${_USE_FRAMEWORKS_EXTRA} ${_USE_FRAMEWORKS_EXTRA}
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines
kimageformats_PORT= graphics/kf5-kimageformats kimageformats_PORT= graphics/kf5-kimageformats
kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so
kimageformats_TYPE= run kimageformats_TYPE= run
kio_PORT= devel/kf5-kio kio_PORT= devel/kf5-kio
kio_LIB= libKF5KIOCore.so kio_LIB= libKF5KIOCore.so
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami_PORT= x11-toolkits/kirigami kirigami_PORT= x11-toolkits/kirigami
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami2_PORT= x11-toolkits/kirigami2
kirigami2_PATH= ${QT_QMLDIR}/org/kde/kirigami.2/libkirigamiplugin.so
kross_PORT= lang/kf5-kross kross_PORT= lang/kf5-kross
kross_LIB= libKF5KrossCore.so kross_LIB= libKF5KrossCore.so
mediaplayer_PORT= multimedia/kf5-kmediaplayer mediaplayer_PORT= multimedia/kf5-kmediaplayer
mediaplayer_LIB= libKF5MediaPlayer.so.5 mediaplayer_LIB= libKF5MediaPlayer.so.5
newstuff_PORT= devel/kf5-knewstuff newstuff_PORT= devel/kf5-knewstuff
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines
View Options

head/contrib/netbsd-tests/lib/libc/c063/t_fstatat.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
KDE4_WORKSPACE_VERSION= 4.11.21 KDE4_WORKSPACE_VERSION= 4.11.21
KDE4_KDEPIM_VERSION?= 4.14.10 KDE4_KDEPIM_VERSION?= 4.14.10
# Applications version for the kde4-applications. # Applications version for the kde4-applications.
KDE4_APPLICATIONS_BRANCH?= Attic KDE4_APPLICATIONS_BRANCH?= Attic
KDE4_APPLICATIONS_VERSION?= 15.04.3 KDE4_APPLICATIONS_VERSION?= 15.04.3
KDE4_BRANCH?= stable KDE4_BRANCH?= stable
# Current KDE desktop. # Current KDE desktop.
KDE_FRAMEWORKS_VERSION?= 5.30.0 KDE_FRAMEWORKS_VERSION?= 5.31.0
KDE_FRAMEWORKS_BRANCH?= stable KDE_FRAMEWORKS_BRANCH?= stable
# Current KDE applications. # Current KDE applications.
KDE_APPLICATIONS_VERSION?= 16.12.0 KDE_APPLICATIONS_VERSION?= 16.12.0
KDE_APPLICATIONS_BRANCH?= stable KDE_APPLICATIONS_BRANCH?= stable
# Upstream moves old software to Attic/. Specify the newest applications release there. # Upstream moves old software to Attic/. Specify the newest applications release there.
# Only the major version is used for the comparison. # Only the major version is used for the comparison.
_KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3 _KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3
▲ Show 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
# Porting Aids frameworks provide code and utilities to ease the transition from # Porting Aids frameworks provide code and utilities to ease the transition from
# kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework, # kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework,
# new projects should avoid using these libraries. # new projects should avoid using these libraries.
_USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross _USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross
# These are weird items: not officially released as Frameworks, but # These are weird items: not officially released as Frameworks, but
# required by them (and from KDE). # required by them (and from KDE).
# - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui # - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui
_USE_FRAMEWORKS_EXTRA= kirigami _USE_FRAMEWORKS_EXTRA= kirigami kirigami2
_USE_FRAMEWORKS_ALL= ecm \ _USE_FRAMEWORKS_ALL= ecm \
${_USE_FRAMEWORKS_TIER1} \ ${_USE_FRAMEWORKS_TIER1} \
${_USE_FRAMEWORKS_TIER2} \ ${_USE_FRAMEWORKS_TIER2} \
${_USE_FRAMEWORKS_TIER3} \ ${_USE_FRAMEWORKS_TIER3} \
${_USE_FRAMEWORKS_TIER4} \ ${_USE_FRAMEWORKS_TIER4} \
${_USE_FRAMEWORKS_PORTING} \ ${_USE_FRAMEWORKS_PORTING} \
${_USE_FRAMEWORKS_EXTRA} ${_USE_FRAMEWORKS_EXTRA}
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines
kimageformats_PORT= graphics/kf5-kimageformats kimageformats_PORT= graphics/kf5-kimageformats
kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so
kimageformats_TYPE= run kimageformats_TYPE= run
kio_PORT= devel/kf5-kio kio_PORT= devel/kf5-kio
kio_LIB= libKF5KIOCore.so kio_LIB= libKF5KIOCore.so
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami_PORT= x11-toolkits/kirigami kirigami_PORT= x11-toolkits/kirigami
kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
kirigami2_PORT= x11-toolkits/kirigami2
kirigami2_PATH= ${QT_QMLDIR}/org/kde/kirigami.2/libkirigamiplugin.so
kross_PORT= lang/kf5-kross kross_PORT= lang/kf5-kross
kross_LIB= libKF5KrossCore.so kross_LIB= libKF5KrossCore.so
mediaplayer_PORT= multimedia/kf5-kmediaplayer mediaplayer_PORT= multimedia/kf5-kmediaplayer
mediaplayer_LIB= libKF5MediaPlayer.so.5 mediaplayer_LIB= libKF5MediaPlayer.so.5
newstuff_PORT= devel/kf5-knewstuff newstuff_PORT= devel/kf5-knewstuff
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines
View Options

head/lib/libc/tests/c063/Makefile

Loading...