Page MenuHomeFreeBSD
Differential D1411

Link lib/libc/c063 tests to the build.
ClosedPublic
Actions

Authored by jilles on Jan 2 2015, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 12:08 PM
Unknown Object (File)
Mon, Apr 14, 7:33 AM
Unknown Object (File)
Mon, Apr 14, 5:58 AM
Unknown Object (File)
Mon, Apr 14, 5:54 AM
Unknown Object (File)
Mon, Apr 14, 5:42 AM
Unknown Object (File)
Fri, Apr 11, 2:44 PM
Unknown Object (File)
Mar 8 2025, 11:49 AM
Unknown Object (File)
Feb 20 2025, 2:08 AM
View All Files
Subscribers
None

Details

Reviewers
ngie
jmmv
Commits
rS276590: Link lib/libc/c063 tests to the build.
Summary

Some files lack required #include <sys/stat.h>.

The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with
faccessat(), which is not specified by POSIX.1-2008.

Test Plan

buildworld and installworld, kyua test in /usr/tests/lib/libc/c063.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jilles updated this revision to Diff 2950.Jan 2 2015, 1:26 PM
jilles retitled this revision from to Link lib/libc/c063 tests to the build..
jilles updated this object.
jilles edited the test plan for this revision. (Show Details)
jilles added reviewers: ngie, jmmv.
ngie edited edge metadata.Jan 2 2015, 8:07 PM

Thanks! Forgot to complete this..

contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c
43 ↗(On Diff #2950)

Please put these if #ifdef FreeBSD #endif blocks so I don't forget to upstream them to NetBSD..

ngie added a comment.Jan 2 2015, 8:09 PM

"The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with
faccessat(), which is not specified by POSIX.1-2008."

The testcase should either be #ifdef NetBSD'ed out, or have a block like this added to it:

#ifdef __FreeBSD__
atf_tc_expect_fail("Depends on non-standard behavior not mentioned in POSIX.1-2008");
#endif
jilles updated this revision to Diff 2964.Jan 2 2015, 10:28 PM
jilles edited edge metadata.

Apply changes requested by ngie. 'kyua test' in c063/ is happy now.

ngie accepted this revision.Jan 2 2015, 10:43 PM
ngie edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 10:43 PM
jilles closed this revision.Jan 2 2015, 10:49 PM
jilles updated this revision to Diff 2965.

Closed by commit rS276590 (authored by @jilles).

Revision Contents
Changeset List

PathSize
head/
contrib/
netbsd-tests/
lib/
libc/
c063/
3 lines
3 lines
3 lines
3 lines
lib/
libc/
tests/
c063/
30 lines

Diff 2965

View Options

head/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines if (bootverbose) {
unit->unit, busno, slot, func); unit->unit, busno, slot, func);
} }
return (false); return (false);
} }
iommu_set_buswide_ctx(unit, busno); iommu_set_buswide_ctx(unit, busno);
return (true); return (true);
} }
void
iommu_set_buswide_ctx(struct iommu_unit *unit, u_int busno)
kibUnsubmitted
Not Done
Inline Actions

I still prefer to have this code fragment to exist as a function.

kib: I still prefer to have this code fragment to exist as a function.
{
MPASS(busno <= PCI_BUSMAX);
IOMMU_LOCK(unit);
unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] |=
1 << (busno % (NBBY * sizeof(uint32_t)));
IOMMU_UNLOCK(unit);
}
bool
iommu_is_buswide_ctx(struct iommu_unit *unit, u_int busno)
{
MPASS(busno <= PCI_BUSMAX);
return ((unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] &
(1U << (busno % (NBBY * sizeof(uint32_t))))) != 0);
}
static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map"); static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map");
static void iommu_bus_schedule_dmamap(struct iommu_unit *unit, static void iommu_bus_schedule_dmamap(struct iommu_unit *unit,
struct bus_dmamap_iommu *map); struct bus_dmamap_iommu *map);
static int static int
iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment,
bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr, bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr,
▲ Show 20 Lines • Show All 714 Lines • Show Last 20 Lines
View Options

head/contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines if (bootverbose) {
unit->unit, busno, slot, func); unit->unit, busno, slot, func);
} }
return (false); return (false);
} }
iommu_set_buswide_ctx(unit, busno); iommu_set_buswide_ctx(unit, busno);
return (true); return (true);
} }
void
iommu_set_buswide_ctx(struct iommu_unit *unit, u_int busno)
kibUnsubmitted
Not Done
Inline Actions

I still prefer to have this code fragment to exist as a function.

kib: I still prefer to have this code fragment to exist as a function.
{
MPASS(busno <= PCI_BUSMAX);
IOMMU_LOCK(unit);
unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] |=
1 << (busno % (NBBY * sizeof(uint32_t)));
IOMMU_UNLOCK(unit);
}
bool
iommu_is_buswide_ctx(struct iommu_unit *unit, u_int busno)
{
MPASS(busno <= PCI_BUSMAX);
return ((unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] &
(1U << (busno % (NBBY * sizeof(uint32_t))))) != 0);
}
static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map"); static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map");
static void iommu_bus_schedule_dmamap(struct iommu_unit *unit, static void iommu_bus_schedule_dmamap(struct iommu_unit *unit,
struct bus_dmamap_iommu *map); struct bus_dmamap_iommu *map);
static int static int
iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment,
bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr, bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr,
▲ Show 20 Lines • Show All 714 Lines • Show Last 20 Lines
View Options

head/contrib/netbsd-tests/lib/libc/c063/t_fchownat.c

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines if (bootverbose) {
unit->unit, busno, slot, func); unit->unit, busno, slot, func);
} }
return (false); return (false);
} }
iommu_set_buswide_ctx(unit, busno); iommu_set_buswide_ctx(unit, busno);
return (true); return (true);
} }
void
iommu_set_buswide_ctx(struct iommu_unit *unit, u_int busno)
kibUnsubmitted
Not Done
Inline Actions

I still prefer to have this code fragment to exist as a function.

kib: I still prefer to have this code fragment to exist as a function.
{
MPASS(busno <= PCI_BUSMAX);
IOMMU_LOCK(unit);
unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] |=
1 << (busno % (NBBY * sizeof(uint32_t)));
IOMMU_UNLOCK(unit);
}
bool
iommu_is_buswide_ctx(struct iommu_unit *unit, u_int busno)
{
MPASS(busno <= PCI_BUSMAX);
return ((unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] &
(1U << (busno % (NBBY * sizeof(uint32_t))))) != 0);
}
static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map"); static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map");
static void iommu_bus_schedule_dmamap(struct iommu_unit *unit, static void iommu_bus_schedule_dmamap(struct iommu_unit *unit,
struct bus_dmamap_iommu *map); struct bus_dmamap_iommu *map);
static int static int
iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment,
bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr, bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr,
▲ Show 20 Lines • Show All 714 Lines • Show Last 20 Lines
View Options

head/contrib/netbsd-tests/lib/libc/c063/t_fstatat.c

Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines if (bootverbose) {
unit->unit, busno, slot, func); unit->unit, busno, slot, func);
} }
return (false); return (false);
} }
iommu_set_buswide_ctx(unit, busno); iommu_set_buswide_ctx(unit, busno);
return (true); return (true);
} }
void
iommu_set_buswide_ctx(struct iommu_unit *unit, u_int busno)
kibUnsubmitted
Not Done
Inline Actions

I still prefer to have this code fragment to exist as a function.

kib: I still prefer to have this code fragment to exist as a function.
{
MPASS(busno <= PCI_BUSMAX);
IOMMU_LOCK(unit);
unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] |=
1 << (busno % (NBBY * sizeof(uint32_t)));
IOMMU_UNLOCK(unit);
}
bool
iommu_is_buswide_ctx(struct iommu_unit *unit, u_int busno)
{
MPASS(busno <= PCI_BUSMAX);
return ((unit->buswide_ctxs[busno / NBBY / sizeof(uint32_t)] &
(1U << (busno % (NBBY * sizeof(uint32_t))))) != 0);
}
static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map"); static MALLOC_DEFINE(M_IOMMU_DMAMAP, "iommu_dmamap", "IOMMU DMA Map");
static void iommu_bus_schedule_dmamap(struct iommu_unit *unit, static void iommu_bus_schedule_dmamap(struct iommu_unit *unit,
struct bus_dmamap_iommu *map); struct bus_dmamap_iommu *map);
static int static int
iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, iommu_bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment,
bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr, bus_addr_t boundary, bus_addr_t lowaddr, bus_addr_t highaddr,
▲ Show 20 Lines • Show All 714 Lines • Show Last 20 Lines
View Options

head/lib/libc/tests/c063/Makefile

Loading...