Page MenuHomeFreeBSD
Differential D11101

Templates/config.site : Update for FreeBSD 10
ClosedPublic
Actions

Authored by rene on Jun 8 2017, 6:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 16 2025, 2:40 PM
Unknown Object (File)
Jan 13 2025, 6:27 AM
Unknown Object (File)
Jan 13 2025, 6:24 AM
Unknown Object (File)
Nov 23 2024, 6:34 PM
Unknown Object (File)
Nov 22 2024, 7:45 PM
Unknown Object (File)
Nov 22 2024, 5:01 AM
Unknown Object (File)
Nov 21 2024, 2:42 AM
Unknown Object (File)
Nov 18 2024, 7:58 PM
View All 80 Files
Subscribers
mat

Details

Reviewers
bdrewery
Group Reviewers
portmgr
Commits
rP443121: Add more functions to the autoconf cache that appeared in FreeBSD 9 or 10.
Summary

Update Templates/config.site to use the new features available in FreeBSD 9 and 10

Test Plan

exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
head/
Templates/
14 linesO5: Ports Framework

Diff 29446

View Options

head/Templates/config.site

Show First 20 Lines • Show All 530 Lines • ▼ Show 20 Lines if (vs2 != NULL)
TAILQ_INSERT_BEFORE(vs2, vs, link); TAILQ_INSERT_BEFORE(vs2, vs, link);
else else
TAILQ_INSERT_TAIL(&vnet_constructors, vs, link); TAILQ_INSERT_TAIL(&vnet_constructors, vs, link);
/* /*
* Invoke the constructor on all the existing vnets when it is * Invoke the constructor on all the existing vnets when it is
* registered. * registered.
*/ */
VNET_LIST_RLOCK();
VNET_FOREACH(vnet) { VNET_FOREACH(vnet) {
CURVNET_SET_QUIET(vnet); CURVNET_SET_QUIET(vnet);
vs->func(vs->arg); vs->func(vs->arg);
CURVNET_RESTORE(); CURVNET_RESTORE();
} }
VNET_LIST_RUNLOCK();
VNET_SYSINIT_WUNLOCK(); VNET_SYSINIT_WUNLOCK();
} }
void void
vnet_deregister_sysinit(void *arg) vnet_deregister_sysinit(void *arg)
{ {
struct vnet_sysinit *vs; struct vnet_sysinit *vs;
Show All 34 Linesvnet_deregister_sysuninit(void *arg)
struct vnet *vnet; struct vnet *vnet;
vs = arg; vs = arg;
/* /*
* Invoke the destructor on all the existing vnets when it is * Invoke the destructor on all the existing vnets when it is
* deregistered. * deregistered.
*/ */
VNET_LIST_RLOCK();
zleiUnsubmitted
Not Done
Inline Actions

In vnet_register_sysinit() we have lock order

VNET_SYSINIT_WLOCK();
VNET_LIST_RLOCK;

I think it is best to make lock order consistent with that in vnet_register_sysinit(), although dead lock is not possible.

zlei: In `vnet_register_sysinit()` we have lock order ``` VNET_SYSINIT_WLOCK(); VNET_LIST_RLOCK; ```…
VNET_SYSINIT_WLOCK(); VNET_SYSINIT_WLOCK();
VNET_FOREACH(vnet) { VNET_FOREACH(vnet) {
CURVNET_SET_QUIET(vnet); CURVNET_SET_QUIET(vnet);
vs->func(vs->arg); vs->func(vs->arg);
CURVNET_RESTORE(); CURVNET_RESTORE();
} }
/* Remove the destructor from the global list of vnet destructors. */ /* Remove the destructor from the global list of vnet destructors. */
TAILQ_REMOVE(&vnet_destructors, vs, link); TAILQ_REMOVE(&vnet_destructors, vs, link);
VNET_LIST_RUNLOCK();
VNET_SYSINIT_WUNLOCK(); VNET_SYSINIT_WUNLOCK();
} }
mjgUnsubmitted
Not Done
Inline Actions

you should unlock in the same order for consistency

the VNET_FOREACH macro should presumably assert on the lock?

mjg: you should unlock in the same order for consistency the VNET_FOREACH macro should presumably…
kpAuthorUnsubmitted
Not Done
Inline Actions

It should, but the locking for the vnet list uses two different locks for reasons I do not currently understand.
So we'd have to MPASS(sx_locked(&vnet_sxlock) || rw_rowned(&vnet_rwlock));. Which is doubly annoying because rw_rowned() doesn't exist.

kp: It should, but the locking for the vnet list uses two different locks for reasons I do not…
mjgUnsubmitted
Not Done
Inline Actions

that is a gap i'm going to plug

mjg: that is a gap i'm going to plug
zleiUnsubmitted
Not Done
Inline Actions

you should unlock in the same order for consistency

I'd prefer to unlock in the reverse order. That is more natural for me.
Anyway unlock order does not matter much.

the VNET_FOREACH macro should presumably assert on the lock?

ipreass_drain() in sys/netinet/ip_reass.c also miss read lock.
I think it is good to have read lock assert in macro VNET_FOREACH .

zlei: > you should unlock in the same order for consistency I'd prefer to unlock in the reverse…
/* /*
* Invoke all registered vnet constructors on the current vnet. Used during * Invoke all registered vnet constructors on the current vnet. Used during
* vnet construction. The caller is responsible for ensuring the new vnet is * vnet construction. The caller is responsible for ensuring the new vnet is
* the current vnet and that the vnet_sysinit_sxlock lock is locked. * the current vnet and that the vnet_sysinit_sxlock lock is locked.
*/ */
static void static void
vnet_sysinit(void) vnet_sysinit(void)
▲ Show 20 Lines • Show All 235 Lines • Show Last 20 Lines