Page MenuHomeFreeBSD

Make x11-themes/adwaita-qt[45] slave ports of x11-themes/adwaita-common and update to 0.99
ClosedPublic

Authored by tcberner on May 10 2017, 9:27 PM.
Tags
None
Referenced Files
F150265142: D10671.id.diff
Mon, Mar 30, 6:05 PM
Unknown Object (File)
Sun, Mar 29, 1:57 PM
Unknown Object (File)
Wed, Mar 25, 4:31 AM
Unknown Object (File)
Tue, Mar 24, 2:16 AM
Unknown Object (File)
Mon, Mar 23, 11:09 PM
Unknown Object (File)
Sun, Mar 22, 5:22 PM
Unknown Object (File)
Sat, Mar 21, 11:20 PM
Unknown Object (File)
Wed, Mar 18, 4:07 AM
Subscribers
None

Details

Summary
  • Update to 0.99
  • Make them all slaves
  • Take maintainership

I think QT[45]_USES and QT[45]_PLIST could be somehow stuck into one, however the best thing I could come up with was ${OPTIONS_SLAVE}_USES=... which would however also set it for the -common port...

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9560
Build 10007: arc lint + arc unit

Event Timeline

Combine USES and PLIST.. ok, did save one line...

Update to 1.0.

Is this change non-invasive enough for implicit?

lgtm

x11-themes/adwaita-common/Makefile
28

At first this looks a bit confusing, as it appears you're doing COMMON_USES=cmake:outsource [...]. I think a comment clarifying what's being done here with ?= makes sense.

This revision is now accepted and ready to land.May 29 2017, 10:38 AM
This revision was automatically updated to reflect the committed changes.