Page MenuHomeFreeBSD
Differential D10860

Fix build/packaging when PREFIX+LOCALBASE are not /usr/local.
ClosedPublic
Actions

Authored by bdrewery on May 22 2017, 5:46 PM.
Tags
None
Referenced Files
F156831796: D10860.id28689.diff
Sat, May 16, 6:57 PM
F156831780: D10860.id28689.diff
Sat, May 16, 6:56 PM
Unknown Object (File)
Wed, May 13, 11:01 AM
Unknown Object (File)
Mon, May 11, 5:41 PM
Unknown Object (File)
Mon, May 11, 4:12 PM
Unknown Object (File)
Mon, May 11, 3:09 PM
Unknown Object (File)
Sun, May 10, 5:18 PM
Unknown Object (File)
Sun, May 10, 5:17 PM
View All Files
Subscribers
mat

Details

Reviewers
kwm
Group Reviewers
gnome
Commits
rP441489: Fix build when PREFIX is not /usr/local.
Test Plan

Built it with a different PREFIX+LOCALBASE.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9448
Build 9901: arc lint + arc unit

Event Timeline

bdrewery created this revision.May 22 2017, 5:46 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 22 2017, 5:46 PM
Harbormaster completed remote builds in B9445: Diff 28685.May 22 2017, 5:46 PM
bdrewery added a comment.May 22 2017, 5:46 PM

No PORTREVISION bump is needed since it is purely a build fix.

bdrewery added a comment.May 22 2017, 5:49 PM

Hrm, it's not quite working. Hitting some bug in check-plist. The basic change here is still right though - that /usr/local should not be hardcoded. Looking for proper fix.

bdrewery updated this revision to Diff 28686.May 22 2017, 5:50 PM

Use working %%LOCALBASE%%

Harbormaster completed remote builds in B9446: Diff 28686.May 22 2017, 5:51 PM
bdrewery updated this revision to Diff 28689.May 22 2017, 7:02 PM

Use PREFIX, which is stored in RESETPREFIX by bsd.port.mk.

Harbormaster completed remote builds in B9448: Diff 28689.May 22 2017, 7:02 PM
kwm accepted this revision as: gnome.May 22 2017, 7:03 PM

Looks good. Can you refer https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218659 in the commit? thanks

Closed by commit rP441489: Fix build when PREFIX is not /usr/local. (authored by bdrewery). · Explain WhyMay 22 2017, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
glib20/
4 lines

Diff 28689

View Options

devel/glib20/pkg-plist

Loading...