Page MenuHomeFreeBSD

makefs: clean up warnings, fix style, bring changes over from NetBSD
AbandonedPublic

Authored by siva on May 17 2017, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 2 2025, 7:53 AM
Unknown Object (File)
Nov 21 2025, 1:50 AM
Unknown Object (File)
Nov 21 2025, 1:50 AM
Unknown Object (File)
Nov 21 2025, 1:46 AM
Unknown Object (File)
Nov 4 2025, 1:26 AM
Unknown Object (File)
Nov 3 2025, 1:00 PM
Unknown Object (File)
Oct 22 2025, 3:02 AM
Unknown Object (File)
Oct 22 2025, 3:02 AM
Subscribers
None

Details

Reviewers
emaste
ngie
Summary

Submitted by emaste:

  • Whitespace fixes
  • Remove all warnings and set WARNS=6
  • Make buf generic (origin NetBSD)
    • ffs.c: 1.58
    • ffs/buf.c: 1.18
    • ffs/buf.h: 1.8
  • Comment out increment of blkno in getblk() (origin NetBSD)
    • ffs/buf.c: 1.14

Submitted by smahadevan:

  • fixed bug with bread getting wrong offset and sectorsize (origin NetBSD):
    • ffs.c: 1.59
    • ffs/buf.c: 1.19
    • ffs/buf.h: 1.9
    • ffs/ffs_alloc.c: 1.23
    • ffs/ffs_balloc.c: 1.17
    • ffs/ufs_inode.h: 1.5
    • makefs.h: 1.32
Test Plan

No functionality changes, reran makefs and fstyp tests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Review is outdated, will be uploading independent reviews for whitespace changes and the bread bug fix. See https://reviews.freebsd.org/D10650.