Page MenuHomeFreeBSD

Make x11-themes/adwaita-qt[45] slave ports of x11-themes/adwaita-common and update to 0.99
ClosedPublic

Authored by tcberner on May 10 2017, 9:27 PM.
Tags
None
Referenced Files
F83959315: D10671.diff
Fri, May 17, 10:15 AM
Unknown Object (File)
Fri, May 3, 11:17 PM
Unknown Object (File)
Tue, Apr 30, 10:54 PM
Unknown Object (File)
Sun, Apr 28, 5:45 AM
Unknown Object (File)
Sat, Apr 20, 7:16 PM
Unknown Object (File)
Sat, Apr 20, 7:16 PM
Unknown Object (File)
Sat, Apr 20, 7:16 PM
Unknown Object (File)
Sat, Apr 20, 7:16 PM
Subscribers
None

Details

Summary
  • Update to 0.99
  • Make them all slaves
  • Take maintainership

I think QT[45]_USES and QT[45]_PLIST could be somehow stuck into one, however the best thing I could come up with was ${OPTIONS_SLAVE}_USES=... which would however also set it for the -common port...

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9179
Build 9622: arc lint + arc unit

Event Timeline

Combine USES and PLIST.. ok, did save one line...

Update to 1.0.

Is this change non-invasive enough for implicit?

lgtm

x11-themes/adwaita-common/Makefile
28

At first this looks a bit confusing, as it appears you're doing COMMON_USES=cmake:outsource [...]. I think a comment clarifying what's being done here with ?= makes sense.

This revision is now accepted and ready to land.May 29 2017, 10:38 AM
This revision was automatically updated to reflect the committed changes.