This is for DRM. We only implement the blocking form (wait == 1),
since that's all our smp_rendezvous implements. But that's what almost
all callers in Linux use anyway.
Details
Details
- Reviewers
• hselasky - Commits
- rS317651: Add on_each_cpu() and wbinvd_on_all_cpus().
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/compat/linuxkpi/common/src/linux_compat.c | ||
---|---|---|
1640 ↗ | (On Diff #27869) | A stylistic question - this follows Linux APIs in calls from this function; is that preferable to having the Linux API only at the interface, and using FreeBSD routines internally (i.e. here calling smp_rendezvous instead?) For this case it makes little difference of course, but I'm curious about the two approaches in general. |
sys/compat/linuxkpi/common/src/linux_compat.c | ||
---|---|---|
1640 ↗ | (On Diff #27869) | Oops - I had actually meant to use the internal interface there. I do think it's preferable to avoid using the external interfaces, but in some cases (e.g., spin_lock()) that's not very practical right now. |