Page MenuHomeFreeBSD

Fix Shebangs
ClosedPublic

Authored by tcberner on Apr 27 2017, 7:08 PM.
Tags
None
Referenced Files
F80144151: D10527.id27940.diff
Thu, Mar 28, 1:00 PM
Unknown Object (File)
Sat, Mar 16, 11:11 AM
Unknown Object (File)
Mon, Mar 11, 12:28 PM
Unknown Object (File)
Sun, Mar 10, 8:55 PM
Unknown Object (File)
Sun, Mar 10, 8:55 PM
Unknown Object (File)
Sun, Mar 10, 8:55 PM
Unknown Object (File)
Sun, Mar 10, 8:55 PM
Unknown Object (File)
Sun, Mar 10, 8:55 PM
Subscribers
None

Details

Summary
  • comms/gnuradio
  • graphics/hugin
  • math/asymptote - also modify patch-Makefile.in and post-patch, as one of the files is generated on the fly.
  • science/afni

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8950
Build 9342: arc lint + arc unit

Event Timeline

  • x11-wm/fvwm2 - add PYTHON=${PYTHON_CMD} to the configure environment to fix shebangs
  • x11-wm/fvwm-crystal
devel/libdbusmenu/Makefile
25–32

So you are adding python as a dependency so that a tool that nobody will ever use gets the right shebang ? It is ludicrous, please don't.

math/asymptote/files/patch-Makefile.in
16–17

There is no real need for the patch, you could simply use /usr/bin/env python in the sed line in the Makefile.

x11-wm/fvwm2/Makefile
26–27 ↗(On Diff #27809)

Same here, it never needed python before, now it requires it to run ?

devel/libdbusmenu/Makefile
25–32

according to INDEX it depends on python anyways, no?

So should this shebang error just be ignored?

devel/libdbusmenu/Makefile
25–32

There are talks about reducing the pain for the python interpreter shebang thing, only if the port depends on python.

Now, if this already has python as a run dependencies through some dependency, it may be ok. Be sure to say so when you commit it.

  • Get rid of patch in math/asymptote
  • x11/mate-applets
  • math/kig - python is already an implicit run time dependency anyways.

Regenerate against current tree.

Looks ok, you might want to investigate using SHEBANG_REGEX or SHEBANG_GLOB in some cases.

This revision is now accepted and ready to land.May 3 2017, 10:15 AM
This revision was automatically updated to reflect the committed changes.