Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF).
ClosedPublic
Actions

Authored by brooks on Apr 27 2017, 12:31 AM.

Details

Reviewers

asomers
ngie

Commits

rS317566: Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF).

Summary

These command take an int. The tests work by accident on little-endian
systems.

Tested with: qemu-cheri and CheriBSD built for mips64
Obtained from: CheriBSD
Sponsored by: DARPA, AFRL
MFC after: 1 week

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8928
Build 9318: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 27 2017, 12:31 AM

Harbormaster completed remote builds in B8928: Diff 27771.Apr 27 2017, 12:31 AM

Oops. LGTM. This seems like a good candidate for a Coverity check.

This revision is now accepted and ready to land.Apr 27 2017, 2:44 AM

I've added a not even compiled change in D10519 which would have caught this.

brooks edited the summary of this revision. (Show Details)Apr 27 2017, 4:17 AM

Could you please add testing done on the Cheri emulator?

In D10518#217952, @ngie wrote:

Could you please add testing done on the Cheri emulator?

I'm not sure what you're asking. FYI, this is broken on all big-endian 64-bit systems.

brooks edited the summary of this revision. (Show Details)Apr 28 2017, 3:35 PM

Closed by commit rS317566: Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF). (authored by brooks). · Explain WhyApr 28 2017, 5:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

unix_seqpacket_test.c

20 lines

Diff 27771

View Options

tests/sys/kern/unix_seqpacket_test.c

Don't pass size_t arguments to setsockopt(SO_SNDBUF/SO_RCVBUF).ClosedPublicActions