Backport clang r221170 to implement va_arg support for PowerPC
ClosedPublic
Actions

Authored by dim on Dec 13 2014, 10:31 PM.

Details

Reviewers

nwhitehorn
jhibbits

Commits

rS275872: MFC r275759:
rS275759: Pull in r221170 from upstream clang trunk (by Roman Divacky):

Summary

Pull in r221170 from upstream clang trunk (by Roman Divacky):

Implement vaarg lowering for ppc32. Lowering of scalars and
aggregates is supported. Complex numbers are not.

Test Plan

Since I have no way of knowing whether this works correctly or not, I would like both a sanity check, and a check that this results in working va_args support on real PowerPC hardware.

I did build it, both with clang and gcc (I had to remove one C++11-ism), and it should compile OK.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dim updated this revision to Diff 2735.Dec 13 2014, 10:31 PM

dim retitled this revision from to Backport clang r221170 to implement va_arg support for PowerPC.

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added reviewers: jhibbits, nwhitehorn.

Just tested, it passes the llvm upstream ppc-varargs-struct.c test. Thanks for merging it!

This revision is now accepted and ready to land.Dec 14 2014, 5:29 AM

Closed by commit rS275759 (authored by @dim).

Revision Contents
Changeset List

Path

Size

contrib/

llvm/

tools/

clang/

lib/

CodeGen/

TargetInfo.cpp

104 lines

Diff 2735

View Options

contrib/llvm/tools/clang/lib/CodeGen/TargetInfo.cpp

Backport clang r221170 to implement va_arg support for PowerPCClosedPublicActions