Add a section about the order the variables must come in a Makefile.
ClosedPublic
Actions

Authored by mat on Mar 31 2017, 2:56 PM.

Details

Reviewers

wblock
bcr

Group Reviewers

Doc Committers

Commits

rD50190: Add a section about the order the variables must come in a Makefile.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8455
Build 8752: arc lint + arc unit

Event Timeline

mat created this revision.Mar 31 2017, 2:56 PM

wblock added inline comments.Mar 31 2017, 4:24 PM

en_US.ISO8859-1/books/porters-handbook/porting-samplem/chapter.xml
103	s/Ports/Port/
105	The first sections of the <filename>Makefile</filename>
106	This standard makes it so everyone
107	can easily read any port without having to search for variables in a random order.
110	<para>The first line of a <filename>Makefile</filename> is always
112	s/RCS ID/VCS ID/ actually, `version control ID``` is probably clearer. s/will look/looks/
119	has expanded it to look like this:</para>
125	s/only//
126	s/normal/ordinary/
134	In the following blocks, only set the variables that are required by the port. Define these variables in the order they are shown here.</para>
142	Comma splice. <para>This block is the most important. It defines the port
143	name, version, distribution file location, and category. The
144	variables must be in this order:</para>
266	Better off without a count of variables to get out of sync: <para>This block is mandatory. The variables are:</para>
284	s/thought/although it is/
343	s/by/variables by/
397	"Always" is not necessary, make it imperative: <para>Keep related variables close together. For example,
433	the same order as the different stages run:</para>

mat marked 18 inline comments as done.Apr 3 2017, 12:09 PM

wblock's comments.

Harbormaster completed remote builds in B8454: Diff 26951.Apr 3 2017, 12:10 PM

igor.

Harbormaster completed remote builds in B8455: Diff 26952.Apr 3 2017, 12:20 PM

mat added a reviewer: Doc Committers.Apr 18 2017, 10:12 AM

Looks good to me.

This revision is now accepted and ready to land.Apr 18 2017, 1:07 PM

mat added a parent revision: Restricted Differential Revision.Apr 18 2017, 4:18 PM

Closed by commit rD50190: Add a section about the order the variables must come in a Makefile. (authored by mat). · Explain WhyApr 21 2017, 1:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

en_US.ISO8859-1/

books/

porters-handbook/

porting-samplem/

chapter.xml

365 lines

Diff 26952

View Options

en_US.ISO8859-1/books/porters-handbook/porting-samplem/chapter.xml

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines

	static bool nl_process_nbuf(struct nl_buf nb, struct nlpcb nlp);			static bool nl_process_nbuf(struct nl_buf nb, struct nlpcb nlp);

	struct nl_buf *			struct nl_buf *
	nl_buf_alloc(size_t len, int mflag)			nl_buf_alloc(size_t len, int mflag)
	{			{
	struct nl_buf *nb;			struct nl_buf *nb;

				KASSERT(len > 0 && len <= UINT_MAX, ("%s: invalid length %zu",
				__func__, len));

	nb = malloc(sizeof(struct nl_buf) + len, M_NETLINK, mflag);			nb = malloc(sizeof(struct nl_buf) + len, M_NETLINK, mflag);
	if (__predict_true(nb != NULL)) {			if (__predict_true(nb != NULL)) {
	nb->buflen = len;			nb->buflen = len;
	nb->datalen = nb->offset = 0;			nb->datalen = nb->offset = 0;
	}			}

	return (nb);			return (nb);
	}			}
	▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines

Add a section about the order the variables must come in a Makefile.ClosedPublicActions