Skip call CPU_ISSET for NOCPU.
ClosedPublic
Actions

Authored by dchagin on Dec 8 2014, 9:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 15, 10:28 PM

	Unknown Object (File)
	Wed, Apr 15, 8:11 PM

	Unknown Object (File)
	Wed, Apr 15, 2:21 PM

	Unknown Object (File)
	Sun, Apr 12, 10:37 AM

	Unknown Object (File)
	Fri, Apr 10, 3:18 PM

	Unknown Object (File)
	Thu, Apr 9, 9:33 AM

	Unknown Object (File)
	Tue, Mar 24, 12:43 PM

	Unknown Object (File)
	Sun, Mar 22, 11:42 PM

View All Files

Subscribers

None

Details

Reviewers

jhb

Commits

rS275644: Skip calling CPU_ISSET for NOCPU as a short period of time we can have

Summary

I have core where td_state is TDS_RUNNING and td_oncpu is NOCPU. It seems for short time we can have this,
so skip call CPU_ISSET for NOCPU to prevent kgdb from crashing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dchagin updated this revision to Diff 2685.Dec 8 2014, 9:18 PM

dchagin retitled this revision from to Skip call CPU_ISSET for NOCPU..

dchagin updated this object.

dchagin added a reviewer: jhb.

jhb added inline comments.Dec 8 2014, 10:14 PM

gnu/usr.bin/gdb/kgdb/kthr.c
100 ↗	(On Diff #2685)	Probably you can just drop the td_state test entirely then and only test td_oncpu.

Closed by commit rS275644 (authored by @dchagin).

Revision Contents
Changeset List

Path

Size

head/

gnu/

usr.bin/

gdb/

kgdb/

kthr.c

2 lines

Diff 2690

View Options

head/gnu/usr.bin/gdb/kgdb/kthr.c

Skip call CPU_ISSET for NOCPU.ClosedPublicActions