loader: efipart should check disk size from partition table
ClosedPublic
Actions

Authored by tsoome on Mar 30 2017, 11:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 10, 8:55 PM

	Unknown Object (File)
	Fri, May 10, 6:44 PM

	Unknown Object (File)
	Thu, May 9, 8:30 PM

	Unknown Object (File)
	Wed, May 1, 11:08 AM

	Unknown Object (File)
	Sun, Apr 28, 12:58 PM

	Unknown Object (File)
	Dec 24 2023, 10:23 PM

	Unknown Object (File)
	Dec 20 2023, 3:07 AM

	Unknown Object (File)
	Nov 9 2023, 3:16 AM

View All 11 Files

Subscribers

None

Details

Reviewers

allanjude
imp

Commits

rS316279: loader: efipart should check disk size from partition table

Summary

While testing 32bit UEFI OVMF (which has bug about how the disk size
is presented), I did witness the errors from blkio->ReadBlocks().

It became apparent we can not entirely trust UEFI interfaces either,
so additional checks are needed.

So we use disk_ioctl(DIOCGMEDIASIZE) for disks, with fallback of
Media->LastBlock for other media.

In addition, we need to check if there is media present.

+ small fixes for error printout, and avoiding multiple blk * 512.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Mar 30 2017, 11:38 AM

Harbormaster completed remote builds in B8388: Diff 26816.Mar 30 2017, 11:38 AM

Approved By: allanjude

This revision is now accepted and ready to land.Mar 30 2017, 3:47 PM

Closed by commit rS316279: loader: efipart should check disk size from partition table (authored by tsoome). · Explain WhyMar 30 2017, 4:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

libefi/

efipart.c

37 lines

Diff 26832

View Options

head/sys/boot/efi/libefi/efipart.c

loader: efipart should check disk size from partition tableClosedPublicActions