Page MenuHomeFreeBSD
Differential D1036

Implement a Linux version of sched_getparam() && sched_setparam(). Temporarily use the first thread in proc.
ClosedPublic
Actions

Authored by dchagin on Oct 31 2014, 6:24 AM.
Tags
None
Referenced Files
F122364574: D1036.id.diff
Fri, Jul 4, 4:53 PM
F122321838: D1036.id2166.diff
Fri, Jul 4, 8:39 AM
Unknown Object (File)
Thu, Jul 3, 6:20 AM
Unknown Object (File)
Thu, Jul 3, 3:24 AM
Unknown Object (File)
Thu, Jul 3, 12:00 AM
Unknown Object (File)
Mon, Jun 30, 8:26 PM
Unknown Object (File)
Mon, Jun 23, 10:34 PM
Unknown Object (File)
Wed, Jun 11, 9:32 AM
View All Files
Subscribers
emaste

Details

Reviewers
trasz
Group Reviewers
Linux Emulation
Commits
rS283379: Implement a Linux version of sched_getparam() && sched_setparam().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2166.Oct 31 2014, 6:24 AM
dchagin retitled this revision from to Implement a Linux version of sched_getparam() && sched_setparam(). Temporarily use the first thread in proc..
dchagin added a reviewer: Linux Emulation.Oct 31 2014, 6:54 AM
emaste added a subscriber: emaste.Dec 4 2014, 3:54 PM

Looks fine to me. Can you add an XXX comment on the FIRST_THREAD_IN_PROC to comment on what is desired instead.

trasz accepted this revision.Dec 5 2014, 10:34 AM
trasz added a reviewer: trasz.
This revision is now accepted and ready to land.Dec 5 2014, 10:34 AM
trasz added a comment.Dec 5 2014, 10:47 AM

Hm, actually, looking at the diff this depends on, I'd prefer the callers (in this case, linux_sched_setparam() et al) to drop the proc lock, instead of kern_sched_setparam(). So, this might require some small changes.

dchagin updated this revision to Diff 2665.Dec 6 2014, 6:09 PM
dchagin edited edge metadata.

Unlock proc lock.

This revision now requires review to proceed.Dec 6 2014, 6:09 PM
dchagin updated this revision to Diff 2666.Dec 6 2014, 6:21 PM
dchagin edited edge metadata.

XXX comment added about Linux scheduleing.

trasz accepted this revision.Dec 8 2014, 10:17 AM
trasz edited edge metadata.
This revision is now accepted and ready to land.Dec 8 2014, 10:17 AM
Closed by commit rS283379: Implement a Linux version of sched_getparam() && sched_setparam(). (authored by dchagin). · Explain WhyMay 24 2015, 2:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux32/
8 lines
compat/
linux/
67 lines
i386/
linux/
8 lines

Diff 2665

View Options

sys/amd64/linux32/syscalls.master

Loading...
View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/i386/linux/syscalls.master

Loading...