Page MenuHomeFreeBSD

tighten buffer bounds in imgact_binmisc_populate_interp
ClosedPublic

Authored by emaste on Mar 17 2017, 7:32 PM.
Tags
None
Referenced Files
F168778760: D10042.diff
Sun, Aug 30, 2:56 AM
F168777192: D10042.id.diff
Sun, Aug 30, 2:45 AM
Unknown Object (File)
Fri, Aug 28, 12:37 PM
Unknown Object (File)
Thu, Aug 27, 1:36 PM
Unknown Object (File)
Wed, Aug 26, 5:18 PM
Unknown Object (File)
Wed, Aug 26, 5:08 PM
Unknown Object (File)
Wed, Aug 26, 3:46 PM
Unknown Object (File)
Tue, Aug 25, 12:08 PM
Subscribers
None

Details

Summary

We must ensure there's space for the terminating null in the temporary buffer in imgact_binmisc_populate_interp().

Note that there is not a possible buffer overflow here, because xbe->xbe_interpreter's length and null termination is checked in imgact_binmisc_add_entry() before imgact_binmisc_populate_interp() is called, but the latter should correctly enforce its own bounds.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 21 2017, 3:03 PM
This revision was automatically updated to reflect the committed changes.