COPYTREE_SHARE should also be using _SHAREMODE and not SHAREMODE.
ClosedPublic
Actions

Authored by mat on Aug 24 2016, 9:32 AM.

Details

Reviewers

antoine
swills

Group Reviewers

portmgr

Commits

rP436276: COPYTREE_SHARE should also be using _SHAREMODE and not SHAREMODE.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mat updated this revision to Diff 19619.Aug 24 2016, 9:32 AM

mat retitled this revision from to COPYTREE_SHARE should also be using _SHAREMODE and not SHAREMODE..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptAug 24 2016, 9:32 AM

LGTM, perhaps INSTALL_LIB should get the same change as well?

This revision is now accepted and ready to land.Jan 26 2017, 5:12 PM

Looks good to me too and I believe this would fix a few stage failures as a regular user with strip(1) from elftoolchain.
Do you want an exp-run?

Mmm, I had forgotten about this one, I think I rewrote the COPYTREE_SHARE macros since then, so the patch will not apply, let me regen this and add INSTALL_LIB to it too.

rebase.

This revision now requires review to proceed.Mar 13 2017, 3:37 PM

Harbormaster completed remote builds in B8033: Diff 26218.Mar 13 2017, 3:37 PM

Exp-run looks fine

This revision is now accepted and ready to land.Mar 15 2017, 6:54 PM

Closed by commit rP436276: COPYTREE_SHARE should also be using _SHAREMODE and not SHAREMODE. (authored by mat). · Explain WhyMar 16 2017, 1:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

bsd.port.mk

4 lines

O5: Ports Framework

Diff 26315

View Options

COPYTREE_SHARE should also be using _SHAREMODE and not SHAREMODE.ClosedPublicActions