security/sha1collisiondetection - tool to detect SHA-1 collisions
ClosedPublic
Actions

Authored by jrm on Mar 14 2017, 1:21 PM.

Details

Reviewers

swills
AMDmi3

Commits

rP436161: Setting ALL_TARGET in the port Makefile is not necessary when there is a
rP436160: security/sha1collisiondetection: Remove redundant library entry from
rP436154: security/sha1collisiondetection: a tool to detect SHA-1 collisions

Summary

security/sha1collisiondetection - tool to detect SHA-1 collisions

Remaining port issues:

Using MAKE_ARGS+=PREFIX=${STAGEDIR}${PREFIX} puts everything in the correct staging locations, but the binaries link to the full staging paths for the shared libraries.
Manually staging with INSTALL_PROGRAM gives errors when stripping the binaries (strip:...security/sha1collisiondetection/work/stage/usr/local/bin/sha1dcsum: File format not recognized).

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8046
Build 8233: arc lint + arc unit

Event Timeline

jrm created this revision.Mar 14 2017, 1:21 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 14 2017, 1:21 PM

Harbormaster completed remote builds in B8044: Diff 26248.Mar 14 2017, 1:21 PM

mat added inline comments.Mar 14 2017, 1:38 PM

security/sha1collisiondetection/Makefile
2	Please don't add new ports with `Created by` lines.
23	`s/+=/=/`
32–40	Don't add commented-out bits. Also, as a side note, NEVER, EVER, use `do-install` and `post-install` at the same time, just use `do-install`.

Update from work-in-progress to something that installs.

Harbormaster completed remote builds in B8046: Diff 26250.Mar 14 2017, 2:08 PM

Closed by commit rP436154: security/sha1collisiondetection: a tool to detect SHA-1 collisions (authored by jrm). · Explain WhyMar 14 2017, 2:17 PM

This revision was automatically updated to reflect the committed changes.

jrm marked an inline comment as done.

INSTALL_PROGRAM is only for binaries. If you get errors, it's most likely the files with error are scripts and should be installed with INSTALL_SCRIPT.

As it builds itself, it feels like it should be able to install itself. What kind of errors do you get when you try to install it with the provided build framework ? Have you tried USES=desthack ?