Page MenuHomeFreeBSD
Differential D9972

Take maintainership for x11/yakuake-kde4 and rename it to x11/yakuake (to be replaced by the kf5-version in the future).
ClosedPublic
Actions

Authored by tcberner on Mar 12 2017, 8:47 AM.
Tags
None
Referenced Files
F161408692: D9972.id.diff
Fri, Jul 3, 12:33 PM
F161388203: D9972.id26235.diff
Fri, Jul 3, 8:21 AM
F161386742: D9972.id26219.diff
Fri, Jul 3, 8:05 AM
Unknown Object (File)
Thu, Jul 2, 8:47 PM
Unknown Object (File)
Thu, Jul 2, 8:31 PM
Unknown Object (File)
Tue, Jun 30, 9:39 PM
Unknown Object (File)
Thu, Jun 25, 8:09 AM
Unknown Object (File)
Sat, Jun 20, 10:14 AM
View All Files
Subscribers
None

Details

Reviewers
rakuco
mat
Group Reviewers
kde
Commits
rP436112: Take maintainership of x11/yakuake-kde4
Summary
  • Rename the port
  • Take maintainership

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner created this revision.Mar 12 2017, 8:47 AM
Harbormaster completed remote builds in B8011: Diff 26178.Mar 12 2017, 8:47 AM
rakuco edited edge metadata.Mar 12 2017, 10:16 AM

Is there a reason not to move to 3.0.2 in the same commit? Does the KF5 work fine on KDE4?

MOVED
9134 ↗(On Diff #26178)

There's an older entry for x11/yakuake that needs to be removed.

tcberner updated this revision to Diff 26184.Mar 12 2017, 11:04 AM
  • Include the update to 3.0.2

I don't see a reason why it would not work with KDE4. As I do not have KDE4, I
would be happy, if you could give it a go though.

Harbormaster completed remote builds in B8017: Diff 26184.Mar 12 2017, 11:04 AM
tcberner marked an inline comment as done.Mar 12 2017, 11:05 AM
rakuco added a comment.Mar 12 2017, 7:18 PM

I tried it here with KDE4 from ports. Yakuake launches, but fails to show any terminal with an error message saying "Yakuake was unable to load the Konsole component. A Konsole installation is required to use Yakuake".

tcberner updated this revision to Diff 26195.Mar 12 2017, 9:03 PM

Don't update it yet -- as rakuco@ pointed out, it needs a kf5-based konsole installation.

Harbormaster completed remote builds in B8022: Diff 26195.Mar 12 2017, 9:03 PM
rakuco added a comment.Mar 13 2017, 3:17 PM

To be honest, I don't see a lot of value in renaming the port while keeping it KDE4-based (even the reasoning in MOVED looks a bit weak in this case). How about just taking maintainership, and then renaming/updating the port once the Konsole5 KPart makes its way to the tree?

tcberner added a comment.Mar 13 2017, 3:42 PM

You're probably right ^^.

tcberner updated this revision to Diff 26219.Mar 13 2017, 3:43 PM

chomp chomp

Harbormaster completed remote builds in B8034: Diff 26219.Mar 13 2017, 3:43 PM
tcberner added a comment.Mar 13 2017, 3:44 PM

Does MAINTAINER change still require a PORTVERSION bump?

mat edited edge metadata.Mar 13 2017, 3:46 PM

no, it is metadata.

rakuco accepted this revision.Mar 13 2017, 8:23 PM

lgtm

This revision is now accepted and ready to land.Mar 13 2017, 8:23 PM
Closed by commit rP436112: Take maintainership of x11/yakuake-kde4 (authored by tcberner). · Explain WhyMar 13 2017, 9:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
x11/
yakuake-kde4/
2 lines

Diff 26235

View Options

head/x11/yakuake-kde4/Makefile

Loading...