Page MenuHomeFreeBSD
Differential D9852

Fix a memory leak in ppp
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 2 2017, 1:41 AM.
Tags
None
Referenced Files
F131718032: D9852.diff
Fri, Oct 10, 2:51 PM
Unknown Object (File)
Sat, Sep 27, 1:08 AM
Unknown Object (File)
Thu, Sep 18, 6:50 AM
Unknown Object (File)
Sat, Sep 13, 6:34 AM
Unknown Object (File)
Sep 10 2025, 12:21 AM
Unknown Object (File)
Sep 9 2025, 10:30 PM
Unknown Object (File)
Sep 9 2025, 6:20 AM
Unknown Object (File)
Sep 9 2025, 12:23 AM
View All Files
Subscribers
imp

Details

Reviewers
stevek
Commits
rS319638: Before returning because of an memory allocation error, free the memory
Summary

ppp iface.c
Before returning because of an memory allocation error, free the memory already allocated to buf.

Test Plan

Run clang's static analyzer, scan-build, to find the problem and to show it is resolved.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trix_juniper.net updated this revision to Diff 25855.Mar 2 2017, 1:41 AM
trix_juniper.net retitled this revision from to Fix a memory leak in ppp.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added a reviewer: stevek.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMar 2 2017, 1:41 AM
stevek accepted this revision.Mar 2 2017, 10:39 PM
stevek edited edge metadata.

Looks reasonable to me.

This revision is now accepted and ready to land.Mar 2 2017, 10:39 PM
Closed by commit rS319638: Before returning because of an memory allocation error, free the memory (authored by stevek). · Explain WhyJun 6 2017, 9:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
1 line

Diff 25855

View Options

usr.sbin/ppp/iface.c

Loading...