Differential D9802

remove procfs ctl interface
ClosedPublic
Actions

Authored by badger on Feb 25 2017, 5:16 PM.

Details

Reviewers

vangyzen

Commits

rS314690: remove procfs ctl interface

Summary

This interface has no in-tree consumers and has in fact been
non-functional for several releases.

Remove manpage note that the procfs special file 'mem' is grouped to
kmem. This hasn't been true since r81107.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7735
Build 7882: arc lint + arc unit

Event Timeline

badger updated this revision to Diff 25692.Feb 25 2017, 5:16 PM

badger retitled this revision from to remove procfs ctl interface.

badger updated this object.

badger edited the test plan for this revision. (Show Details)

Herald added a subscriber: vangyzen. · View Herald TranscriptFeb 25 2017, 5:16 PM

OK from the manpages part of the change. Make sure to bump the document date when you commit.
Do we need an entry in ObsoleteFiles.inc for the deleted sys/fs/procfs/procfs_ctl.c ?

vangyzen accepted this revision.Feb 27 2017, 2:37 PM

vangyzen added a reviewer: vangyzen.

vangyzen added inline comments.

sys/fs/procfs/README
35	The BSD kernel is single-processor? Wow. Please consider deleting this whole file. There are a few tiny differences between this and the man page, but I think we can assume the man page is more accurate in those places.

This revision is now accepted and ready to land.Feb 27 2017, 2:37 PM

Remove procfs' README file

It is an out of date duplication of the manpage (quoth the README:
"since the bsd kernel is single-processor...").

This revision now requires review to proceed.Feb 27 2017, 3:18 PM

vangyzen accepted this revision.Feb 27 2017, 3:21 PM

vangyzen edited edge metadata.

This revision is now accepted and ready to land.Feb 27 2017, 3:21 PM

In D9802#202491, @bcr wrote:

OK from the manpages part of the change. Make sure to bump the document date when you commit.
Do we need an entry in ObsoleteFiles.inc for the deleted sys/fs/procfs/procfs_ctl.c ?

Thanks for the review. No obsolete files since it all compiles down to a single module.

Closed by commit rS314690: remove procfs ctl interface (authored by badger). · Explain WhyMar 5 2017, 3:05 AM

This revision was automatically updated to reflect the committed changes.