makefs: eliminate global cd9660 structure
ClosedPublic
Actions

Authored by emaste on Feb 16 2017, 1:51 AM.

Details

Reviewers

ngie
marcel

Commits

rS314117: makefs: eliminate global cd9660 structure

Summary

For diff reduction with NetBSD.

cd9660.c 1.39
cd9660.h 1.19
cd9660/cd9660_debug.c 1.12
cd9660/cd9660_eltorito.c 1.20
cd9660/cd9660_write.c 1.16
cd9660/iso9660_rrip.c 1.12
cd9660/iso9660_rrip.h 1.6

Obtained from: NetBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 25257.Feb 16 2017, 1:51 AM

emaste retitled this revision from to makefs: eliminate global cd9660 structure.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: ngie, marcel.

Could you please run the tests (cd tests; sudo make install; sudo make check)?

cd9660 tests pass except:

makefs_cd9660_tests:D_flag -> skipped: makefs crashes with SIGBUS with dupe mtree entries; see FreeBSD bug # 192839
makefs_cd9660_tests:o_flag_allow_max_name: expected_failure: -o allow-max-name doesn't appear to be implemented on FreeBSD's copy of makefs [yet]
makefs_cd9660_tests:o_flag_isolevel_1: expected_failure: this testcase needs work; the filenames generated seem incorrect/corrupt

In D9627#200819, @emaste wrote:

cd9660 tests pass except:

makefs_cd9660_tests:D_flag -> skipped: makefs crashes with SIGBUS with dupe mtree entries; see FreeBSD bug # 192839
makefs_cd9660_tests:o_flag_allow_max_name: expected_failure: -o allow-max-name doesn't appear to be implemented on FreeBSD's copy of makefs [yet]
makefs_cd9660_tests:o_flag_isolevel_1: expected_failure: this testcase needs work; the filenames generated seem incorrect/corrupt

LGTM (those are ok).

This revision is now accepted and ready to land.Feb 22 2017, 10:39 PM

Closed by commit rS314117: makefs: eliminate global cd9660 structure (authored by emaste). · Explain WhyFeb 23 2017, 2:28 AM

This revision was automatically updated to reflect the committed changes.