Page MenuHomeFreeBSD
Differential D9645

db show pte: use pmap of kdb_thread
ClosedPublic
Actions

Authored by rlibby on Feb 17 2017, 7:24 AM.
Tags
None
Referenced Files
F105786384: D9645.id25497.diff
Fri, Dec 20, 4:39 PM
F105769916: D9645.diff
Fri, Dec 20, 11:02 AM
Unknown Object (File)
Mon, Nov 25, 8:04 PM
Unknown Object (File)
Sat, Nov 23, 11:55 PM
Unknown Object (File)
Nov 13 2024, 4:00 PM
Unknown Object (File)
Oct 25 2024, 2:48 AM
Unknown Object (File)
Oct 15 2024, 4:22 AM
Unknown Object (File)
Sep 21 2024, 8:33 AM
View All 53 Files
Subscribers
None

Details

Reviewers
kib
Commits
rS314057: ddb show pte: use pmap of kdb_thread
Summary

db show pte: use pmap of kdb_thread

show pte from the pmap of the process of the current DDB thread,
instead of necessarily the PCPU pmap.

I was using this to debug a bug I thought might have been a stale TLB
entry after switching threads (it turned out not to be).

Test Plan

Break into debugger, show pte on a user address, switch threads,
repeat.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby updated this revision to Diff 25295.Feb 17 2017, 7:24 AM
rlibby retitled this revision from to db show pte: use pmap of kdb_thread.
rlibby updated this object.
rlibby edited the test plan for this revision. (Show Details)
rlibby added a reviewer: kib.
kib accepted this revision.Feb 17 2017, 8:21 AM
kib edited edge metadata.
kib added inline comments.
sys/amd64/amd64/pmap.c
7264 ↗(On Diff #25295)

I think that checks for td_proc != NULL and later are somewhat excessive. After proc0 initialization, curpmap != NULL and no thread with NULL td_proc exists. But sure it is innocent.

This revision is now accepted and ready to land.Feb 17 2017, 8:21 AM
rlibby added inline comments.Feb 17 2017, 5:55 PM
sys/amd64/amd64/pmap.c
7264 ↗(On Diff #25295)

Okay. I was thinking about state during thread construction/destruction, but I see now that we wouldn't be able to ddb switch to a thread that isn't thread_link()ed anyway, so that's moot. I'll simplify it.

rlibby updated this revision to Diff 25322.Feb 17 2017, 6:11 PM
rlibby edited edge metadata.

kib feedback: don't be so paranoid about thread pmap linkage

This revision now requires review to proceed.Feb 17 2017, 6:11 PM
rlibby marked 2 inline comments as done.Feb 17 2017, 6:12 PM
kib accepted this revision.Feb 17 2017, 8:39 PM
kib edited edge metadata.
kib added inline comments.
sys/amd64/amd64/pmap.c
7245 ↗(On Diff #25322)

Excessive blank line.

This revision is now accepted and ready to land.Feb 17 2017, 8:39 PM
rlibby updated this revision to Diff 25331.Feb 17 2017, 9:00 PM
rlibby edited edge metadata.

kib feedback: whitespace

This revision now requires review to proceed.Feb 17 2017, 9:00 PM
rlibby marked an inline comment as done.Feb 17 2017, 9:00 PM
Closed by commit rS314057: ddb show pte: use pmap of kdb_thread (authored by markj). · Explain WhyFeb 21 2017, 9:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
13 lines

Diff 25497

View Options

head/sys/amd64/amd64/pmap.c

Loading...